Add path to UM physics includes#567
Conversation
Matthew Hambley (MatthewHambley)
left a comment
There was a problem hiding this comment.
The change itself is fine, but since system testing is the primary route to validation I ask that you perform an "all" test and update the ticket with the result.
For the record, it might be worth mentioning why this change is worthwhile. In the past the UM code was built using the "FCM" tool. This copied anything it found in a directory called include to some central location which was then included on the compilers paths. Hence how these files could be found given the current filename only approach.
Obviously, looking at this change there is no longer any need for this magic as source only ever includes the files right next to them.
Adrian Lock (Adrian-Lock)
left a comment
There was a problem hiding this comment.
Fair enough!
|
I've merged the head on main into the branch and started a run of the all test group, as requested. |
PR Summary
Sci/Tech Reviewer: Matthew Hambley (@MatthewHambley)
Code Reviewer: James Bruten (@james-bruten-mo)
Update pre-processor directives in former UM physics to add
includedirectories to the paths of the header files.Code Quality Checklist
Comments have been included that aid understanding and enhance the readability of the codeTesting
If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)Test Suite Results - lfric_apps - Apps567/run1
Suite Information
Task Information
✅ succeeded tasks - 1594
Security Considerations
Sensitive data is properly handled (if applicable)Authentication and authorisation are properly implemented (if applicable)Performance Impact
Performance of the code has been considered and, if applicable, suitable performance measurements have been conductedAI Assistance and Attribution
Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)Documentation
Where appropriate I have updated documentation related to this change and confirmed that it builds correctlyPSyclone Approval
If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD TeamSci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review