Skip to content

Split up parallel sections to allow further refactors#576

Draft
Benjamin Went (MetBenjaminWent) wants to merge 5 commits into
MetOffice:mainfrom
MetBenjaminWent:refactor-excf_nl_9c
Draft

Split up parallel sections to allow further refactors#576
Benjamin Went (MetBenjaminWent) wants to merge 5 commits into
MetOffice:mainfrom
MetBenjaminWent:refactor-excf_nl_9c

Conversation

@MetBenjaminWent

Copy link
Copy Markdown
Contributor

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

Issue: #571
Umbrella: #106

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@MetBenjaminWent

Copy link
Copy Markdown
Contributor Author

At commit 3
image

@MetBenjaminWent

Copy link
Copy Markdown
Contributor Author

At standard seg size 16, at the top for bl.explicit it doesn't make much difference (note lack of kernels in data)
image

@MetBenjaminWent

Benjamin Went (MetBenjaminWent) commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Post some further work to add nowaits and swap to static blocking, no real positive change, it's still worse off.
image

However, one bonus is that at the top level caliper, nothing really changes as the exchanges are dominating the cost still.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants