update Transmute for conv_gr_kernel_mod#582
Merged
Oakley Brunt (oakleybrunt) merged 8 commits intoJul 15, 2026
Merged
Conversation
Contributor
Author
Contributor
Author
Oakley Brunt (oakleybrunt)
approved these changes
Jul 2, 2026
Oakley Brunt (oakleybrunt)
left a comment
Contributor
There was a problem hiding this comment.
Thanks Ben :D
Hacka Fett (christophermaynard)
approved these changes
Jul 6, 2026
Hacka Fett (christophermaynard)
left a comment
Collaborator
There was a problem hiding this comment.
The changes simplify the transmute scripts and crucially add OpenMP around the main
segmented loop over the domain. Previously, this was missing and so the main loop wasn't parallel. It is with these changes. Approved.
Benjamin Went (MetBenjaminWent)
added a commit
to MetBenjaminWent/lfric_apps
that referenced
this pull request
Jul 10, 2026
Contributor
Author
|
Since move to Psyclone 3.3.1, we need fixes for this PR in #607 (which also contains this PR). |
Oakley Brunt (oakleybrunt)
approved these changes
Jul 14, 2026
Oakley Brunt (oakleybrunt)
left a comment
Contributor
There was a problem hiding this comment.
CR approved
Contributor
Author
Benjamin Went (MetBenjaminWent)
added a commit
to MetBenjaminWent/lfric_apps
that referenced
this pull request
Jul 14, 2026
Oakley Brunt (oakleybrunt)
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Summary
With the existing Transmute script for the


conv_gr_kernel_mod, it seems we are missing coverage, which is affecting perfomance.The script is also very complex, and it could be simpler.
The segment loop in this kernel is extremely important, and core of the existing transmute script. If this is not parallelised with OMP, the entire call stack looses OMP threading coverage. Before these changes, it was not getting OMP coverage, which would explain the issue.
By swapping to using the kernel local script, which puts OMP around all of the
iloops, the coverage has improved, and therefore the OMP performance scaling.Before (Red) and Post (Yellow) changes:

I expect the 1T is the OMP overhead, but this may need further investigations.
Sci/Tech Reviewer: Hacka Fett (@christophermaynard)
Code Reviewer: Oakley Brunt (@oakleybrunt)
PR: #583
Umbrella: #424
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - omp_kernels_grc/run5
Suite Information
Task Information
✅ succeeded tasks - 51
Test Suite Results - lfric_apps - omp_kernels_grc/run6
Suite Information
Task Information
❌ failed tasks - 1
Test Suite Results - lfric_apps - omp_kernels_grc/run7
Suite Information
Task Information
✅ succeeded tasks - 11
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review