Add controls for XIOS buffers#606
Conversation
mo-marqh
left a comment
There was a problem hiding this comment.
a range of detail observations to explore about how to manage default values and configurations.
Additionally, how should the requirements that this change would introduce need to be documented and communicated to suite owners?
Is the documentation in the developer guide sufficient, or should there be configuration documentation for suite owners? release notes?
i think that the Environment Variables are now required by this change, is this all handled for suite owners by the cylc configurations?
Is action expected for suites to update their task_dicts? add Env Vars?
I think this is a broader question that has been ongoing for a while - how to keep suites updated with the changes to rose-stem. In this case, including this change in the release notes is a good idea. I think that most suites do not use the XML files from rose-stem and instead keep a copy within their suites. |
|
|
||
| {% endif %} | ||
|
|
||
| {# RAL configuration XIOS buffer defaults #} |
There was a problem hiding this comment.
i think that perhaps this is on longer required, given the changes you've just made Oakley Brunt (@oakleybrunt) , and risks configuration confusion if left
mo-marqh
left a comment
There was a problem hiding this comment.
there is a default being that will override task_dict settings, that i think needs removing
| {# RAL default = 2Mb #} | ||
| {% do task_dict.update({ | ||
| "xios_min_buffer_size": 2097152, | ||
| }) %} |
There was a problem hiding this comment.
this is still outstanding, and now superseded by the explicit task-dict settings, which is clearer, i think
|
Oops, thanks Mark - that was left by mistake. |
PR Summary
Sci/Tech Reviewer: mo-marqh
Code Reviewer: allynt
PR for issue #600 (XIOS buffer size hard coded)
This PR adds two controls for XIOS buffers into the task-definition dictionary:
xios_min_buffer_sizemin_buffer_sizesetting within XML fileslfric_atmcurrentlylfric_atmandlfric2lfricthat useiodef_ral.xmlhave been updated to use 2097152 (2Mb)xios_buffer_size_factorxios_min_buffer_sizexios_min_buffer_sizeValidation of RAL settings
lfric_atmRALThe value of
xios_min_buffer_sizeshould be set to 2097152, this can be seen working here:lfric_atm_ral3_mixmol-seuk Cylc job file
lfric2lfricRALlfric2lfric_ral_seuk Cylc job file
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - xios-buffers/run3
Suite Information
Task Information
✅ succeeded tasks - 1594
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review