Set mpi-io metadata read for file for read_access scalability#418
Open
mo-marqh wants to merge 1 commit into
Open
Set mpi-io metadata read for file for read_access scalability#418mo-marqh wants to merge 1 commit into
mo-marqh wants to merge 1 commit into
Conversation
11 tasks
Collaborator
|
No issues with this. I'd be happy to Code Review if a suitably XIOS expert sci/tech review is done. |
Steve Mullerworth (stevemullerworth)
left a comment
Collaborator
There was a problem hiding this comment.
As noted above, could I ask for a sci/tech review please.
Copilot kindly reviewed the current IO meeting notes to see if there was a firm recommendation that this should be done, but it couldn't find one. In absence of that, it would be good to have evidence of a test or a discussion within the team that has demonstrated or advised there will be a net benefit from this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: Steve Mullerworth (@stevemullerworth)
For scalability for large rank counts of simulation ranks then it is essential that XIOS is instructed to avoid using serial netCDF calls to call
nc_openon HDF5 encoded netCDF files.XIOS uses MPI-IO collective calls for data interactions by default (good for scale) and provides an opt-in switch to use MPI-IO for metadata reads
read_metadata_parread_metadata_parBut, this operates on a file object, so needs to be managed many times, or deep within the LFRic interface.
This PR proposes a full opt in of this for all uses.
Preliminary analyses show that this is not problematic at small scales and very useful at large scales.
More nuanced implementations could be explored, but do not yet seem justified, compared to this simple full opt in
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - read_metadata_par_lfric_xios/run1
Suite Information
Task Information
✅ succeeded tasks - 427
Test Suite Results - lfric_apps - io_trace_intercept-nc_open_par/run5
Suite Information
Task Information
✅ succeeded tasks - 8
Timer Comparison
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review