Skip to content

Commit 7f1d7b0

Browse files
committed
CH-240 fix backwards compatibility
1 parent b003eb6 commit 7f1d7b0

6 files changed

Lines changed: 5 additions & 8 deletions

File tree

docs/model/RegistrySecretConfig.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
Name | Type | Description | Notes
88
------------ | ------------- | ------------- | -------------
9-
**name** | **str** | The name of the secret to create for docker registry credentials |
9+
**name** | **str** | The name of the secret to create for docker registry credentials | [optional]
1010
**value** | **str** | The value of the secret to create for docker registry credentials. This should be the raw JSON content of the Google Cloud service account key used for the registry. | [optional]
1111

1212
## Example

libraries/models/api/openapi.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@ components:
126126
additionalProperties: true
127127
RegistrySecretConfig:
128128
description: ''
129-
required:
130-
- name
131129
type: object
132130
properties:
133131
name:

libraries/models/cloudharness_model/models/registry_secret_config.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libraries/models/docs/RegistrySecretConfig.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

libraries/models/test-requirements.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,3 @@ pytest-cov>=2.8.1
33
pytest-randomly>=3.12.0
44
mypy>=1.4.1
55
types-python-dateutil>=2.8.19
6-
oyaml

tools/deployment-cli-tools/harness-deployment

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ if __name__ == "__main__":
4545

4646
parser.add_argument('-r', '--registry', dest='registry', action="store", default='',
4747
help='Specify image registry prefix')
48-
parser.add_argument('-rsn', '--registry-secret-name', dest='registry_secret_name', action="store", default='',
49-
help='Specify image registry secret')
48+
parser.add_argument('-rsn', '-rs', '--registry-secret-name', dest='registry_secret_name', action="store", default='',
49+
help='Specify image registry secret (-rs is deprecated, use -rsn)')
5050
parser.add_argument('-o', '--output', dest='output_path', action="store", default='./deployment',
5151
help='Specify helm chart base path (default `./deployment)`')
5252
parser.add_argument('-d', '--domain', dest='domain', action="store", default="cloudharness.metacell.us",

0 commit comments

Comments
 (0)