(ci-cd) Remove unnecessary test builds from codefresh pipeline

Co-authored-by: Copilot <copilot@github.com>

Author: filippomc

tools/deployment-cli-tools/ch_cli_tools/codefresh.py

@@ -366,12 +366,12 @@ def add_unit_test_step(app_config: ApplicationHarnessConfig):
                 codefresh_steps_from_base_path(join(root_path, APPS_PATH), include=helm_values[KEY_TASK_IMAGES].keys())
                 codefresh_steps_from_base_path(join(root_path, APPS_PATH), include=build_included)
 
-            if CD_E2E_TEST_STEP in steps:
+            if CD_E2E_TEST_STEP in steps and steps[CD_E2E_TEST_STEP].get("scale"):
                 name = "test-e2e"
                 if codefresh_steps_from_base_path(join(root_path, TEST_IMAGES_PATH), include=(name,), publish=False):
                     steps[CD_E2E_TEST_STEP]["image"] = image_tag_with_variables(f"{base_name}/{name}", helm_values.registry.name, app_specific_tag_variable(name))
 
-            if CD_API_TEST_STEP in steps:
+            if CD_API_TEST_STEP in steps and steps[CD_API_TEST_STEP].get("scale"):
                 name = "test-api"
                 if codefresh_steps_from_base_path(join(root_path, TEST_IMAGES_PATH), include=(name,), fixed_context=relpath(root_path, os.getcwd()), publish=False):
                     steps[CD_API_TEST_STEP]["image"] = image_tag_with_variables(f"{base_name}/{name}", helm_values.registry.name, app_specific_tag_variable(name))

tools/deployment-cli-tools/tests/test_codefresh.py

@@ -290,6 +290,11 @@ def test_create_codefresh_configuration_tests():
         assert CD_API_TEST_STEP not in l1_steps, "Api steps are not included in any app"
         assert CD_E2E_TEST_STEP not in l1_steps, "E2E steps are not included in any app"
 
+        all_build_steps = {k: v for k, v in l1_steps.items() if k.startswith(STEP_0[:-1])}
+        built_images = {name for step in all_build_steps.values() for name in step.get("steps", {})}
+        assert "test-e2e" not in built_images, "test-e2e image should not be built when no e2e tests are configured"
+        assert "test-api" not in built_images, "test-api image should not be built when no api tests are configured"
+
     finally:
         shutil.rmtree(BUILD_MERGE_DIR)