feat(metrics): add django prometheus#805
Merged
filippomc merged 1 commit intoMay 29, 2025
Merged
Conversation
filippomc
approved these changes
May 28, 2025
filippomc
left a comment
filippomc
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I'd only change the endpoint to be /metrics
|
|
||
| urlpatterns = [] | ||
|
|
||
| urlpatterns.append(path('prometheus/', include('django_prometheus.urls'))) |
Collaborator
There was a problem hiding this comment.
Usually /metrics is used, it's a kind of convention I'd follow also here
Collaborator
There was a problem hiding this comment.
Maybe adding also the endpoint to the GK white listed by default will make life easier
filippomc
reviewed
May 29, 2025
| Environment :: Web Environment | ||
| Framework :: Django | ||
| Framework :: Django :: 3.2 | ||
| Framework :: Django :: 3.0.7 |
Collaborator
There was a problem hiding this comment.
Why this? We are on django 5 actually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CH-193
adds django-prometheus to CH