Skip to content

liveness probe to check message processing #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filippomc merged 2 commits into from
Apr 22, 2026
Merged

liveness probe to check message processing #848

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0337820
liveness probe to check message processing
ddelpiano Apr 16, 2026
07d9720
fixing timeout flag not used anymore
ddelpiano Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions applications/events/deploy/templates/deployments.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,15 @@ spec:
periodSeconds: 15
timeoutSeconds: 5
livenessProbe:
tcpSocket:
port: client
initialDelaySeconds: 30
exec:
command:
- /bin/sh
- -c
- timeout 10 /opt/kafka/bin/kafka-broker-api-versions.sh --bootstrap-server localhost:9092
Comment on lines +65 to +69

Copilot AI Apr 17, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exec.command list items are indented at the same level as command:, which makes the YAML invalid (the sequence must be nested under the command key). Adjust indentation so the - /bin/sh, - -c, and the actual command are children of command:.

Copilot uses AI. Check for mistakes.
initialDelaySeconds: 60
periodSeconds: 30
timeoutSeconds: 5
timeoutSeconds: 15
failureThreshold: 3
Comment on lines +70 to +73

Copilot AI Apr 16, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This liveness probe starts a Kafka CLI command (which typically spins up a new JVM) every periodSeconds: 30. That can add steady CPU/memory overhead and can become significant on small nodes or under load. Consider increasing the probe period, using a lighter-weight probe implementation, or documenting/confirming the resource impact is acceptable for this deployment.

Copilot uses AI. Check for mistakes.
lifecycle:
preStop:
exec:
Expand Down
Loading