Skip to content

CH-268: Fix name based exclusion in codefresh.py#852

Merged
filippomc merged 1 commit into
developfrom
bugfix/CH-268
May 25, 2026
Merged

CH-268: Fix name based exclusion in codefresh.py#852
filippomc merged 1 commit into
developfrom
bugfix/CH-268

Conversation

@alxbrd

@alxbrd alxbrd commented May 1, 2026

Copy link
Copy Markdown
Contributor

Improve image removal pruning logic when excluding an image with deps used by other images.

Closes CH-268

Improve image removal pruning logic when excluding an image with deps
used by other images.
@alxbrd alxbrd requested review from aranega and filippomc May 1, 2026 14:57

@aranega aranega left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alxbrd ! It looks good to me. I'm only not sure about the fact that we consider unix-path separator in some functions, but perhaps it's an assumption that is done on the whole base code.

Comment thread tools/deployment-cli-tools/ch_cli_tools/codefresh.py

@filippomc filippomc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing, let's fix before merging

@filippomc filippomc merged commit 635b719 into develop May 25, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants