fix: bump overlay retained segs, remove from overlay if all nodes deleted, invalidate history on source change#164
Draft
seankmartin wants to merge 3 commits into
Draft
Conversation
seankmartin
commented
May 13, 2026
- feat: bump default fixed overlay seg limit
- fix: check for source changes for invalidation previously the layer was just checking for if the layer changed away from having spatial skels. But if you change the source, then it never knew and would render stale data and have a stale history which doesn't apply to the source.
- fix: when removing all nodes from a seg, remove in overlay retained seg
previously the layer was just checking for if the layer changed away from having spatial skels. But if you change the source, then it never knew and would render stale data and have a stale history which doesn't apply to the source.
Author
|
Leaving in draft as gives as an idea for the sources, but overall you could have multiple catmaid sources on one layer so I feel like something is a bit not quite right there with that idea. I get the sense that the core problem is that there might be only one overlay, and then each source is putting into the same overlay. If there is an overlay per source then it might more naturally solve this invalidation. There's of course the related issue of what you are editing in such a setup. I believe the retained overlay segment fix should be a pretty harmless one though, unlikely to come up too often however so not a big deal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.