Skip to content

refactor: Deduplicate catmaid spatially indexed skeletons code#165

Merged
seankmartin merged 3 commits into
feature/edit-modefrom
feature/deduplicate_commands_code
May 15, 2026
Merged

refactor: Deduplicate catmaid spatially indexed skeletons code#165
seankmartin merged 3 commits into
feature/edit-modefrom
feature/deduplicate_commands_code

Conversation

@afonsobspinto
Copy link
Copy Markdown
Member

@afonsobspinto afonsobspinto commented May 15, 2026

  • Centralizes spatial skeleton edit action metadata in command_factories.ts, including the action-to-command-property mapping, required vs optional command support, and confidence-configuration requirements.
  • Reuses that metadata for editable source validation, command factory lookup, UI support checks, and public command execution wrappers.
  • Replaces repeated per-action execution logic with shared execution metadata for unsupported-action errors and pending status messages.
  • Consolidates CATMAID spatial skeleton command helpers for created-node cache updates, delete/undo flows, positive segment ID normalization, and CATMAID model-space position validation.
  • Moves shared CATMAID/client, skeleton metadata, and grid-level helpers into reusable modules used by both frontend and backend paths.
  • Renames the CATMAID node-list client method to the generic fetchNodes.
  • Removes the now-unused dedupeSpatiallyIndexedSkeletonEntries helper.
  • Adds/updates tests around shared action routing, editable-source support detection, confidence editing support, and CATMAID API expectations.

@afonsobspinto afonsobspinto marked this pull request as ready for review May 15, 2026 09:07
@afonsobspinto afonsobspinto changed the title Feature/deduplicate commands code refactor: Deduplicate catmaid spatially indexed skeletons code May 15, 2026
@afonsobspinto afonsobspinto requested a review from seankmartin May 15, 2026 09:08
@seankmartin seankmartin merged commit 4ca419b into feature/edit-mode May 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants