add more tests (#976)

Author: Logende

meta_configurator/src/schema/__tests__/schemaManipulationUtils.test.ts

@@ -2,7 +2,10 @@ import {beforeEach, describe, expect, it, vi} from 'vitest';
 import {shallowRef} from 'vue';
 import {ManagedData} from '@/data/managedData';
 import {SessionMode} from '@/store/sessionMode';
-import {extractInlinedSchemaElement} from '@/schema/schemaManipulationUtils';
+import {
+  extractAllInlinedSchemaElements,
+  extractInlinedSchemaElement,
+} from '@/schema/schemaManipulationUtils';
 
 vi.mock('@/dataformats/formatRegistry', () => ({
   useDataConverter: () => ({
@@ -158,4 +161,69 @@ describe('schemaManipulationUtils', () => {
       },
     });
   });
+
+  it('extracts inlined subschemas that are nested inside an existing $defs entry', () => {
+    schemaData = new ManagedData(
+      shallowRef({
+        type: 'object',
+        properties: {
+          vehicle: {
+            $ref: '#/$defs/vehicle',
+          },
+        },
+        $defs: {
+          vehicle: {
+            type: 'object',
+            properties: {
+              path: {
+                type: 'object',
+                properties: {
+                  waypoint: {
+                    type: 'string',
+                  },
+                },
+              },
+              pathCopy: {
+                $ref: '#/$defs/vehicle/properties/path',
+              },
+            },
+          },
+        },
+      }),
+      SessionMode.SchemaEditor
+    );
+
+    const extractedCount = extractAllInlinedSchemaElements(schemaData, false, true);
+
+    expect(extractedCount).toBe(1);
+    expect(schemaData.data.value).toEqual({
+      type: 'object',
+      properties: {
+        vehicle: {
+          $ref: '#/$defs/vehicle',
+        },
+      },
+      $defs: {
+        vehicle: {
+          type: 'object',
+          properties: {
+            path: {
+              $ref: '#/$defs/path',
+            },
+            pathCopy: {
+              $ref: '#/$defs/path',
+            },
+          },
+        },
+        path: {
+          type: 'object',
+          properties: {
+            waypoint: {
+              type: 'string',
+            },
+          },
+        },
+      },
+    });
+  });
 });

meta_configurator/src/utility/__tests__/deleteUtils.test.ts

@@ -0,0 +1,71 @@
+import {beforeEach, describe, expect, it, vi} from 'vitest';
+import {shallowRef} from 'vue';
+import {ManagedData} from '@/data/managedData';
+import {SessionMode} from '@/store/sessionMode';
+import {deleteSchemaElement} from '@/utility/deleteUtils';
+
+vi.mock('@/dataformats/formatRegistry', () => ({
+  useDataConverter: () => ({
+    stringify: (data: any) => JSON.stringify(data),
+    parse: (data: string) => JSON.parse(data),
+  }),
+}));
+
+describe('deleteUtils', () => {
+  let schemaData: ManagedData;
+
+  beforeEach(() => {
+    schemaData = new ManagedData(
+      shallowRef({
+        type: 'object',
+        required: ['name', 'age'],
+        properties: {
+          name: {
+            type: 'string',
+          },
+          age: {
+            type: 'number',
+          },
+          nickname: {
+            type: 'string',
+          },
+        },
+      }),
+      SessionMode.SchemaEditor
+    );
+  });
+
+  it('deletes a schema property and removes it from the parent required list', () => {
+    deleteSchemaElement(schemaData, ['properties', 'name']);
+
+    expect(schemaData.data.value).toEqual({
+      type: 'object',
+      required: ['age'],
+      properties: {
+        age: {
+          type: 'number',
+        },
+        nickname: {
+          type: 'string',
+        },
+      },
+    });
+  });
+
+  it('deletes a non-required schema property without changing the required list', () => {
+    deleteSchemaElement(schemaData, ['properties', 'nickname']);
+
+    expect(schemaData.data.value).toEqual({
+      type: 'object',
+      required: ['name', 'age'],
+      properties: {
+        name: {
+          type: 'string',
+        },
+        age: {
+          type: 'number',
+        },
+      },
+    });
+  });
+});

meta_configurator/src/utility/__tests__/renameUtils.test.ts

@@ -1,5 +1,5 @@
 import {describe, expect, it, vi} from 'vitest';
-import {replacePropertyNameUtils} from '../renameUtils';
+import {replacePropertyNameUtils, updateReferences} from '../renameUtils';
 import {META_SCHEMA_SIMPLIFIED} from '../../packaged-schemas/metaSchemaSimplified';
 import {type Path} from '../path';
 import _ from 'lodash';
@@ -208,4 +208,59 @@ describe('test renameUtils', () => {
       },
     });
   });
+
+  it('updates only matching $ref targets when references are rewritten directly', () => {
+    const currentData = {
+      properties: {
+        source: {
+          type: 'object',
+        },
+        consumer: {
+          $ref: '#/properties/source',
+        },
+        nestedConsumer: {
+          allOf: [
+            {
+              $ref: '#/properties/source/child',
+            },
+          ],
+        },
+        unrelated: {
+          $ref: '#/properties/sourceExtra',
+        },
+      },
+    };
+
+    const updateDataFct = (subPath: Path, newValue: any) => {
+      _.set(currentData, subPath, newValue);
+    };
+
+    updateReferences(
+      ['properties', 'source'],
+      ['properties', 'renamedSource'],
+      currentData,
+      updateDataFct
+    );
+
+    expect(currentData).toEqual({
+      properties: {
+        source: {
+          type: 'object',
+        },
+        consumer: {
+          $ref: '#/properties/renamedSource',
+        },
+        nestedConsumer: {
+          allOf: [
+            {
+              $ref: '#/properties/renamedSource/child',
+            },
+          ],
+        },
+        unrelated: {
+          $ref: '#/properties/sourceExtra',
+        },
+      },
+    });
+  });
 });