Skip to content

fix(ui): prevent newline on Enter during property rename and added ca…#883

Open
Suyog241005 wants to merge 1 commit intoMetaConfigurator:mainfrom
Suyog241005:main
Open

fix(ui): prevent newline on Enter during property rename and added ca…#883
Suyog241005 wants to merge 1 commit intoMetaConfigurator:mainfrom
Suyog241005:main

Conversation

@Suyog241005
Copy link
Copy Markdown

@Suyog241005 Suyog241005 commented Feb 7, 2026

this pr fixes #851

  • pressing Enter during inline property rename now confirms the rename instead of adding a line break.
  • and can cancel it by pressing ESC

@Logende
Copy link
Copy Markdown
Collaborator

Logende commented Feb 8, 2026

Thanks a lot for the PR! I am just now testing it and currently get the following behavior:

Before the PR:

  • On Safari browser, behavior is already correct (enter confirms change)
  • On Google Chrome, enter results in line break instead of confirming change
  • The array keys (e.g. arrow right) can be used to move the cursor across the text while editing

After the PR:

  • In both browsers, enter has no effect on initial creation of a property but properly confirms an edit
  • esc cancels the edit, which is nice
  • the arrow keys now confirm the edit instead of allowing moving the cursor

It would be great if the enter key still allows confirming the creation of a new property and if the arrow keys and others still work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confirming renaming of property

2 participants