fix(parser): correctly parse SS2022 (SIP022) userinfo and retain Base64URL compatibility#50
Open
slackworker wants to merge 1 commit into
Open
Conversation
…eeping Base64URL compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an SS URI parsing bug where SS2022/SIP022 links with standard percent-encoded userinfo (method:password) were not parsed correctly. The parser previously assumed Base64URL-encoded userinfo and missed the SIP022-required case. The fix adds a robust userinfo parser that tries percent-decoding first and falls back to Base64URL decoding, so both new-standard and legacy links are supported.
References
Shadowsocks SIP002
Quoted note: “But for AEAD-2022 (SIP022), userinfo MUST NOT be encoded with Base64URL. When userinfo is not encoded, method and password MUST be percent encoded.”