Skip to content

feat(keyring-snap-bridge): add isSnapKeyring#549

Merged
ccharly merged 4 commits into
mainfrom
cc/feat/is-snap-keyring
May 13, 2026
Merged

feat(keyring-snap-bridge): add isSnapKeyring#549
ccharly merged 4 commits into
mainfrom
cc/feat/is-snap-keyring

Conversation

@ccharly

@ccharly ccharly commented May 13, 2026

Copy link
Copy Markdown
Contributor

A small helper to check and narrow a Keyring (v2) type to SnapKeyring (v2).


Note

Low Risk
Low risk: introduces a pure type-guard helper (keyring.type === KeyringType.Snap) plus unit tests and a changelog entry, without altering keyring behavior.

Overview
Adds isSnapKeyring to the v2 SnapKeyring module as a type-guard helper to detect Snap keyrings by type and narrow Keyring to SnapKeyring.

Extends SnapKeyring.test.ts with coverage for true/false cases and type narrowing, and documents the addition in CHANGELOG.md.

Reviewed by Cursor Bugbot for commit a43b590. Bugbot is set up for automated code reviews on this repo. Configure here.

@ccharly ccharly marked this pull request as ready for review May 13, 2026 13:52
@ccharly ccharly requested a review from a team as a code owner May 13, 2026 13:52
@ccharly ccharly enabled auto-merge May 13, 2026 15:03
@ccharly ccharly added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit 8dfa875 May 13, 2026
40 checks passed
@ccharly ccharly deleted the cc/feat/is-snap-keyring branch May 13, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants