feat(keyring-snap-bridge): add isSnapKeyring#549
Merged
Conversation
montelaidev
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small helper to check and narrow a
Keyring(v2) type toSnapKeyring(v2).Note
Low Risk
Low risk: introduces a pure type-guard helper (
keyring.type === KeyringType.Snap) plus unit tests and a changelog entry, without altering keyring behavior.Overview
Adds
isSnapKeyringto the v2SnapKeyringmodule as a type-guard helper to detect Snap keyrings bytypeand narrowKeyringtoSnapKeyring.Extends
SnapKeyring.test.tswith coverage for true/false cases and type narrowing, and documents the addition inCHANGELOG.md.Reviewed by Cursor Bugbot for commit a43b590. Bugbot is set up for automated code reviews on this repo. Configure here.