fix: expose missing methods in hardware keyrings wrappers#551
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 61a7dea. Configure here.
gantunesr
approved these changes
May 13, 2026
Merged
aUsABuisnessman
pushed a commit
to aUsABuisnessman/accounts
that referenced
this pull request
Jun 23, 2026
## Summary Releases hardware-keyring V2 wrapper additions from MetaMask#551. Bumps the monorepo version to `110.0.0`. ### Included - `@metamask/eth-ledger-bridge-keyring`: `12.0.3` → `12.1.0` - **Added**: Expose device-management pass-throughs on the V2 `LedgerKeyring` wrapper: `hdPath` (getter), `bridge` (getter), `getDeviceId`, `setDeviceId`, `setHdPath`, `getFirstPage`, `getNextPage`, `getPreviousPage`, `forgetDevice`, `isUnlocked`, `attemptMakeApp`, `getAppNameAndVersion`. `forgetDevice` additionally clears the V2 account registry to keep it in sync with the inner keyring. ([MetaMask#551](MetaMask#551)) - `@metamask/eth-qr-keyring`: `2.0.2` → `2.1.0` - **Added**: Expose device-management pass-throughs on the V2 `QrKeyring` wrapper: `getName`, `getMode`, `getFirstPage`, `getNextPage`, `getPreviousPage`, `forgetDevice`. `forgetDevice` additionally clears the V2 account registry to keep it in sync with the inner keyring. ([MetaMask#551](MetaMask#551)) - **Changed**: Bump `@metamask/keyring-sdk` from `^2.0.2` to `^2.1.1` ([MetaMask#544](MetaMask#544), [MetaMask#546](MetaMask#546)) - **Changed**: Bump `@metamask/keyring-utils` from `^3.2.0` to `^3.3.1` ([MetaMask#544](MetaMask#544), [MetaMask#546](MetaMask#546)) - `@metamask/eth-trezor-keyring`: `10.0.2` → `10.1.0` - **Added**: Expose device-management pass-throughs on the V2 `TrezorKeyring` wrapper (inherited by the V2 `OneKeyKeyring`): `getModel`, `hdPath` (getter), `bridge` (getter), `setHdPath`, `getFirstPage`, `getNextPage`, `getPreviousPage`, `forgetDevice`, `isUnlocked`. `forgetDevice` additionally clears the V2 account registry to keep it in sync with the inner keyring. ([MetaMask#551](MetaMask#551)) - **Changed**: Bump `@metamask/keyring-sdk` from `^2.0.2` to `^2.1.1` ([MetaMask#544](MetaMask#544), [MetaMask#546](MetaMask#546)) - **Changed**: Bump `@metamask/keyring-utils` from `^3.2.0` to `^3.3.1` ([MetaMask#544](MetaMask#544), [MetaMask#546](MetaMask#546)) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > This is a release bookkeeping change limited to version bumps and changelog entries, with no functional code changes. Risk is low aside from potential publishing/versioning coordination issues. > > **Overview** > Bumps the monorepo version to `110.0.0` and increments package versions for `@metamask/eth-ledger-bridge-keyring` (`12.1.0`), `@metamask/eth-qr-keyring` (`2.1.0`), and `@metamask/eth-trezor-keyring` (`10.1.0`). > > Updates the keyring changelogs to add the corresponding release sections and adjust the *Unreleased* compare links for the new tags. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d79577c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

There's some missing methods that are needed by the clients.
Note
Medium Risk
Moderate risk because it adds new public surface area and changes
forgetDevicebehavior to also clear the V2 account registry, which could affect client state/caching around device resets.Overview
Exposes missing device-management APIs on the V2 wrapper keyrings so clients can manage paired hardware devices directly via the wrapper.
LedgerKeyring,QrKeyring, andTrezorKeyring(and thusOneKeyKeyring) now pass through getters/methods likehdPath,bridge, paging (getFirstPage/getNextPage/getPreviousPage), and device reset (forgetDevice), plus device-specific calls (e.g. Ledgerget/setDeviceId,attemptMakeApp,getAppNameAndVersion, TrezorgetModel,isUnlocked).forgetDevicealso clears the V2 registry to keep wrapper accounts in sync with the inner keyring, and new unit tests/changelog entries cover these additions.Reviewed by Cursor Bugbot for commit 56e782c. Bugbot is set up for automated code reviews on this repo. Configure here.