fix(transaction-controller): add isInternal: true to ExtraTransactionsPublishHook batch call

Author: matthewwalsh0

packages/transaction-controller/CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Fix `ExtraTransactionsPublishHook` not passing `isInternal: true` when calling `addTransactionBatch`, causing the duplicate-batch-ID guard to incorrectly throw `DuplicateBundleId` (error 5720) for nested ERC-20 gas-fee-token transfers that share a `batchId` with their parent batch ([#8884](https://github.com/MetaMask/core/pull/8884))
+
 ## [66.0.0]
 
 ### Changed

packages/transaction-controller/src/TransactionController.test.ts

@@ -3739,6 +3739,36 @@ describe('TransactionController', () => {
           networkClientId: NETWORK_CLIENT_ID_MOCK,
         });
       });
+
+      it('does not throw if duplicate and isInternal is true', async () => {
+        const { controller } = setupController({
+          options: {
+            state: {
+              transactions: [
+                {
+                  batchId: BATCH_ID_MOCK,
+                } as unknown as TransactionMeta,
+              ],
+            },
+          },
+          updateToInitialState: true,
+        });
+
+        const txParams = {
+          from: ACCOUNT_MOCK,
+          to: ACCOUNT_MOCK,
+        };
+
+        const { result } = await controller.addTransaction(txParams, {
+          batchId: BATCH_ID_MOCK,
+          isInternal: true,
+          networkClientId: NETWORK_CLIENT_ID_MOCK,
+          origin: ORIGIN_MOCK,
+          requireApproval: false,
+        });
+
+        await result.catch(() => {});
+      });
     });
   });
 

packages/transaction-controller/src/hooks/ExtraTransactionsPublishHook.test.ts

@@ -121,6 +121,7 @@ describe('ExtraTransactionsPublishHook', () => {
       disable7702: true,
       disableHook: false,
       disableSequential: true,
+      isInternal: true,
       requireApproval: false,
     });
   });

packages/transaction-controller/src/hooks/ExtraTransactionsPublishHook.ts

@@ -164,6 +164,7 @@ export class ExtraTransactionsPublishHook {
 
     await this.#addTransactionBatch({
       from,
+      isInternal: true,
       networkClientId,
       requireApproval: false,
       transactions,