fix(transaction-pay-controller): fix ESLint errors — JSDoc params, type param name, unused import, unnecessary casts

Author: matthewwalsh0

packages/transaction-pay-controller/src/strategy/fiat/utils.test.ts

@@ -246,7 +246,7 @@ describe('Fiat Utils', () => {
     });
 
     it('returns on-chain ERC-20 amount from receipt logs', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue({
+      PROVIDER_MOCK.request.mockResolvedValue({
         logs: [
           {
             address: ERC20_ADDRESS_MOCK,
@@ -283,7 +283,7 @@ describe('Fiat Utils', () => {
     });
 
     it('falls back to cryptoAmount when receipt is null', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue(null);
+      PROVIDER_MOCK.request.mockResolvedValue(null);
 
       const result = await resolveSourceAmountRaw({
         messenger: resolveMessenger,
@@ -296,9 +296,7 @@ describe('Fiat Utils', () => {
     });
 
     it('falls back to cryptoAmount when on-chain read throws', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockRejectedValue(
-        new Error('Network error'),
-      );
+      PROVIDER_MOCK.request.mockRejectedValue(new Error('Network error'));
 
       const result = await resolveSourceAmountRaw({
         messenger: resolveMessenger,
@@ -311,7 +309,7 @@ describe('Fiat Utils', () => {
     });
 
     it('returns native amount from debug_traceTransaction', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue({
+      PROVIDER_MOCK.request.mockResolvedValue({
         to: WALLET_ADDRESS_MOCK.toLowerCase(),
         value: '0x1bc16d674ec80000',
         calls: [],
@@ -328,7 +326,7 @@ describe('Fiat Utils', () => {
     });
 
     it('falls back to tx.value for native when trace is unsupported', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockImplementation(
+      PROVIDER_MOCK.request.mockImplementation(
         ({ method }: { method: string }) => {
           if (method === 'debug_traceTransaction') {
             return Promise.reject(new Error('Method not found'));

packages/transaction-pay-controller/src/utils/provider.ts

@@ -86,15 +86,20 @@ export function getNetworkClientId(
  * Send an RPC request to the network for the specified chain.
  *
  * @param request - Request parameters.
- * @returns The RPC response typed as `T`.
+ * @param request.messenger - The TransactionPayController messenger.
+ * @param request.chainId - The chain ID to resolve.
+ * @param request.method - The JSON-RPC method name.
+ * @param request.params - Optional parameters for the RPC call.
+ * @param request.options - Resolution options forwarded to {@link getNetworkClientId}.
+ * @returns The RPC response typed as `TResponse`.
  */
-export async function rpcRequest<T = unknown>({
+export async function rpcRequest<TResponse = unknown>({
   messenger,
   chainId,
   method,
   params,
   options,
-}: RpcRequestParams): Promise<T> {
+}: RpcRequestParams): Promise<TResponse> {
   const networkClientId = getNetworkClientId(messenger, chainId, options);
 
   const { provider } = messenger.call(
@@ -106,5 +111,5 @@ export async function rpcRequest<T = unknown>({
 
   log(method, { params, response });
 
-  return response as T;
+  return response as TResponse;
 }

packages/transaction-pay-controller/src/utils/token.test.ts

@@ -613,7 +613,7 @@ describe('Token Utils', () => {
 
   describe('getLiveTokenBalance', () => {
     it('returns ERC-20 balance via eth_call', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue('0x4C4B40');
+      PROVIDER_MOCK.request.mockResolvedValue('0x4C4B40');
 
       const result = await getLiveTokenBalance(
         messenger,
@@ -644,9 +644,7 @@ describe('Token Utils', () => {
     });
 
     it('returns native balance via eth_getBalance', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue(
-        '0xde0b6b3a7640000',
-      );
+      PROVIDER_MOCK.request.mockResolvedValue('0xde0b6b3a7640000');
 
       const result = await getLiveTokenBalance(
         messenger,
@@ -663,9 +661,7 @@ describe('Token Utils', () => {
     });
 
     it('returns native balance for polygon native address', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue(
-        '0x1bc16d674ec80000',
-      );
+      PROVIDER_MOCK.request.mockResolvedValue('0x1bc16d674ec80000');
 
       const result = await getLiveTokenBalance(
         messenger,
@@ -682,7 +678,7 @@ describe('Token Utils', () => {
     });
 
     it('treats native address comparison as case-insensitive', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue('0x1f4');
+      PROVIDER_MOCK.request.mockResolvedValue('0x1f4');
 
       const result = await getLiveTokenBalance(
         messenger,
@@ -699,7 +695,7 @@ describe('Token Utils', () => {
     });
 
     it('uses Infura network client when Infura endpoint is available', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue('0x895440');
+      PROVIDER_MOCK.request.mockResolvedValue('0x895440');
 
       getNetworkConfigurationByChainIdMock.mockReturnValue({
         rpcEndpoints: [
@@ -728,7 +724,7 @@ describe('Token Utils', () => {
     });
 
     it('falls back to default network client when no Infura endpoint is configured', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue('0x6ACFC0');
+      PROVIDER_MOCK.request.mockResolvedValue('0x6ACFC0');
 
       getNetworkConfigurationByChainIdMock.mockReturnValue({
         rpcEndpoints: [
@@ -756,7 +752,7 @@ describe('Token Utils', () => {
     });
 
     it('falls back to default network client when getNetworkConfigurationByChainId throws', async () => {
-      (PROVIDER_MOCK.request as jest.Mock).mockResolvedValue('0x2DC6C0');
+      PROVIDER_MOCK.request.mockResolvedValue('0x2DC6C0');
 
       getNetworkConfigurationByChainIdMock.mockImplementation(() => {
         throw new Error('Network configuration not found');

packages/transaction-pay-controller/src/utils/transaction.ts

@@ -18,7 +18,7 @@ import type {
   UpdateTransactionDataCallback,
 } from '../types';
 import { getAssetsUnifyStateFeature } from './feature-flags';
-import { getNetworkClientId, rpcRequest } from './provider';
+import { rpcRequest } from './provider';
 import { parseRequiredTokens } from './required-tokens';
 import { getNativeToken } from './token';