fix: don't export KeyringControllerErrorMessage from the keyring

controller

Author: Jwhiles

packages/keyring-controller/CHANGELOG.md

@@ -11,7 +11,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Add `KeyringTypes.money` (`'Money Keyring'`) to the `KeyringTypes` enum ([#8204](https://github.com/MetaMask/core/pull/8204))
 - Add `MoneyKeyring` (from `@metamask/eth-money-keyring`) as a built-in default keyring ([#8204](https://github.com/MetaMask/core/pull/8204))
-- Export `KeyringControllerErrorMessage` enum to allow consumers to distinguish specific controller error cases ([#8204](https://github.com/MetaMask/core/pull/8204))
 
 ### Changed
 

packages/keyring-controller/src/index.ts

@@ -1,4 +1,3 @@
 export * from './KeyringController';
 export type * from './types';
 export * from './errors';
-export { KeyringControllerErrorMessage } from './constants';

packages/money-account-service/src/MoneyAccountService.ts

@@ -2,7 +2,6 @@ import { HdKeyring } from '@metamask/eth-hd-keyring';
 import { MONEY_DERIVATION_PATH } from '@metamask/eth-money-keyring';
 import {
   KeyringControllerError,
-  KeyringControllerErrorMessage,
   KeyringTypes,
 } from '@metamask/keyring-controller';
 import type { KeyringMetadata } from '@metamask/keyring-controller';
@@ -91,10 +90,8 @@ export class MoneyAccountService {
         async ({ metadata }) => metadata,
       )
       .catch((error: unknown) => {
-        if (
-          error instanceof KeyringControllerError &&
-          error.message === KeyringControllerErrorMessage.KeyringNotFound
-        ) {
+        if (error instanceof KeyringControllerError) {
+          // TODO: how should we determine whether this is a 'real' error, or something we potentially expect, like not finding a keyring?
           return null;
         }
         throw error;