fix: ignore saved advanced gas fees for bridge transactions (#9401)

## Explanation

Bridge transactions apply the user's **saved advanced gas fees**,
whereas swaps deliberately ignore them.

In `updateGasFees`, saved gas fees are skipped only for
`SWAP_TRANSACTION_TYPES` (`swap`, `swapAndSend`, `swapApproval`).
`bridge` / `bridgeApproval` are not in that list, so a user's saved
advanced gas fees are applied to bridge transactions.

For a user who has saved a low max base fee (observed in production:
`maxBaseFee: "0.05"` gwei, `priorityFee: "0"` for mainnet), every bridge
is submitted **underpriced** — below the current base fee — causing it
to fail (`GAS_TOO_LOW` on the relay) or get stuck as pending. This is
exactly the failure swaps were already protected from.

### Fix

Ignore saved gas fees for bridge transactions as well, via a dedicated
list:

```ts
const SAVED_GAS_FEES_IGNORED_TRANSACTION_TYPES: TransactionType[] = [
  ...SWAP_TRANSACTION_TYPES,
  TransactionType.bridge,
  TransactionType.bridgeApproval,
];
```

I intentionally did **not** add the bridge types to
`SWAP_TRANSACTION_TYPES` itself, because that constant also gates
swap-specific behavior in `updateSwapsTransaction` (e.g. the
`simulationFails` cancel-and-throw, and `transactionNewSwap*` events).
Keeping a separate, purpose-named list decouples "ignore saved gas fees"
from "is a swap".

## References

- Root-caused from production state logs where a bridge smart
transaction was submitted with `maxFeePerGas: 0x2faf080` (0.05 gwei) /
`maxPriorityFeePerGas: 0x0`, sourced from `advancedGasFee["0x1"] = {
maxBaseFee: "0.05", priorityFee: "0" }`.

## Changelog

### `@metamask/transaction-controller`

- **FIXED**: `bridge` and `bridgeApproval` transactions now ignore
user-saved (advanced) gas fees, matching swaps.

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc) for new or updated code as
appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes gas pricing for all internal transactions (bridges, swaps,
etc.); behavior is intentional but affects submission paths where wrong
fees caused production failures.
> 
> **Overview**
> **`updateGasFees`** no longer applies user-saved (advanced) gas fees
when **`txMeta.isInternal`** is true. Saved fees are only loaded for
non-internal (dApp) transactions.
> 
> The previous logic skipped saved fees only for
**`SWAP_TRANSACTION_TYPES`**, so bridge and other internal flows could
inherit a low saved max base fee and submit underpriced txs. The
swap-type check and **`SWAP_TRANSACTION_TYPES`** import were removed in
favor of **`isInternal`**.
> 
> Tests cover applying saved fees for non-internal txs and ignoring them
(without calling **`getSavedGasFees`**) for internal txs. The changelog
documents the fix.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
eb622eb. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: cloudonshore

packages/transaction-controller/CHANGELOG.md

@@ -11,6 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Bump `@metamask/messenger` from `^1.2.0` to `^2.0.0` ([#9392](https://github.com/MetaMask/core/pull/9392))
 
+### Fixed
+
+- Only apply user-saved (advanced) gas fees to dApp transactions ([#9401](https://github.com/MetaMask/core/pull/9401))
+  - Saved advanced gas fees are now ignored for internal transactions (`isInternal`), such as swaps and bridges, whose gas fees are dictated by the aggregator or relay. Previously they were only ignored for swaps, so a user's saved gas fees (e.g. a low max base fee) could underprice a bridge transaction and cause it to fail or get stuck as pending.
+
 ## [68.2.2]
 
 ### Changed

packages/transaction-controller/src/utils/gas-fees.test.ts

@@ -130,6 +130,45 @@ describe('gas-fees', () => {
       );
     });
 
+    describe('saved (advanced) gas fees', () => {
+      const SAVED_GAS_FEES_MOCK = { maxBaseFee: '123', priorityFee: '456' };
+
+      it('are applied for dApp (non-internal) transactions', async () => {
+        updateGasFeeRequest.txMeta.isInternal = false;
+        updateGasFeeRequest.getSavedGasFees.mockReturnValueOnce(
+          SAVED_GAS_FEES_MOCK,
+        );
+
+        await updateGasFees(updateGasFeeRequest);
+
+        expect(updateGasFeeRequest.getSavedGasFees).toHaveBeenCalledTimes(1);
+        expect(updateGasFeeRequest.txMeta.txParams.maxFeePerGas).toBe(
+          '0x1ca35f0e00', // 123 gwei
+        );
+        expect(updateGasFeeRequest.txMeta.userFeeLevel).toBe(
+          UserFeeLevel.CUSTOM,
+        );
+      });
+
+      it('are ignored for internal transactions (e.g. swaps and bridges)', async () => {
+        mockGasFeeFlowMockResponse(FLOW_RESPONSE_FEE_MARKET_MOCK);
+        updateGasFeeRequest.txMeta.isInternal = true;
+        updateGasFeeRequest.getSavedGasFees.mockReturnValueOnce(
+          SAVED_GAS_FEES_MOCK,
+        );
+
+        await updateGasFees(updateGasFeeRequest);
+
+        expect(updateGasFeeRequest.getSavedGasFees).not.toHaveBeenCalled();
+        expect(updateGasFeeRequest.txMeta.txParams.maxFeePerGas).toBe(
+          GAS_HEX_WEI_MOCK,
+        );
+        expect(updateGasFeeRequest.txMeta.userFeeLevel).not.toBe(
+          UserFeeLevel.CUSTOM,
+        );
+      });
+    });
+
     it('deletes gasPrice property if maxPriorityFeePerGas set', async () => {
       updateGasFeeRequest.txMeta.txParams.maxPriorityFeePerGas = GAS_HEX_MOCK;
       updateGasFeeRequest.txMeta.txParams.gasPrice = GAS_HEX_MOCK;

packages/transaction-controller/src/utils/gas-fees.ts

@@ -12,13 +12,11 @@ import type {
   SavedGasFees,
   TransactionParams,
   TransactionMeta,
-  TransactionType,
   GasFeeFlow,
 } from '../types';
 import { GasFeeEstimateType, UserFeeLevel } from '../types';
 import { getGasFeeFlow } from './gas-flow';
 import { rpcRequest } from './provider';
-import { SWAP_TRANSACTION_TYPES } from './swaps';
 
 export type UpdateGasFeesRequest = {
   eip1559: boolean;
@@ -56,10 +54,11 @@ export async function updateGasFees(
   const { txMeta } = request;
   const initialParams = { ...txMeta.txParams };
 
-  const isSwap = SWAP_TRANSACTION_TYPES.includes(
-    txMeta.type as TransactionType,
-  );
-  const savedGasFees = isSwap
+  // User-saved (advanced) gas fees only apply to dApp transactions. Internal
+  // transactions (e.g. swaps and bridges) have their fees dictated by the
+  // aggregator or relay, so applying saved gas fees could underprice them and
+  // cause them to fail or get stuck.
+  const savedGasFees = txMeta.isInternal
     ? undefined
     : request.getSavedGasFees(txMeta.chainId);