chore: add imageUrl (#8448)

## Explanation

Add tokenImageUrl to Position and avgHoldMinutes to TraderStats types
and superstruct schemas so the extension can consume the new API fields.
Also fixes fetchClosedPositions hitting a v2 URL that doesn't exist (the
closed positions endpoint is v1-only), which was causing 404s.

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Touches social API response validation/types and changes the
`fetchClosedPositions` URL selection, which could affect consumers if
the API payloads or endpoints differ from assumptions. Scope is limited
to `@metamask/social-controllers` with updated tests covering the new
fields and endpoint.
> 
> **Overview**
> Adds support for new social-api response fields by extending
`Position`/`PositionStruct` with optional `tokenImageUrl` and
`TraderStats`/`TraderStatsStruct` with optional `medianHoldMinutes`.
> 
> Fixes `fetchClosedPositions` to call the **v1** closed-positions
endpoint (while keeping open positions on v2) to avoid 404s, and updates
tests/changelog accordingly.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
b1fc8cb. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
Co-authored-by: António Regadas <apregadas@gmail.com>
Co-authored-by: Devin Stewart <49423028+Bigshmow@users.noreply.github.com>

Author: 3 people

packages/social-controllers/CHANGELOG.md

@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
+- Add optional `tokenImageUrl` field to `Position` type and `PositionStruct` validation schema ([#8448](https://github.com/MetaMask/core/pull/8448))
+- Add optional `medianHoldMinutes` field to `TraderStats` type and `TraderStatsStruct` validation schema ([#8448](https://github.com/MetaMask/core/pull/8448))
 - Add `intent` and optional `category` fields to `Trade` type ([#8410](https://github.com/MetaMask/core/pull/8410))
 - Export `TradeStruct` superstruct schema; derive `Trade` type via `Infer` ([#8410](https://github.com/MetaMask/core/pull/8410))
 - Narrow `direction` to `'buy' | 'sell'` and `intent` to `'enter' | 'exit'` on `Trade` type ([#8410](https://github.com/MetaMask/core/pull/8410))
@@ -19,6 +21,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Bump `@metamask/messenger` from `^1.1.0` to `^1.1.1` ([#8373](https://github.com/MetaMask/core/pull/8373))
 - Bump `@metamask/base-controller` from `^9.0.1` to `^9.1.0` ([#8457](https://github.com/MetaMask/core/pull/8457))
 
+### Fixed
+
+- Fix `fetchClosedPositions` using v2 URL instead of v1, which caused 404 errors since the closed positions endpoint only exists on v1 ([#8448](https://github.com/MetaMask/core/pull/8448))
+
 ## [0.1.0]
 
 ### Added

packages/social-controllers/src/SocialService.test.ts

@@ -44,6 +44,7 @@ const mockPosition = {
   costBasis: 3000,
   trades: [mockTrade],
   lastTradeAt: 1700000000,
+  tokenImageUrl: 'https://assets.daylight.xyz/images/token-eth.png',
 };
 
 function createMessenger(): SocialServiceMessenger {
@@ -239,6 +240,7 @@ describe('SocialService', () => {
         winRate7d: 0.7,
         roiPercent7d: 1.2,
         tradeCount7d: 15,
+        medianHoldMinutes: 120,
       },
       perChainBreakdown: {
         perChainPnl: { base: 30000 },
@@ -477,7 +479,7 @@ describe('SocialService', () => {
 
       expect(result).toStrictEqual(mockPositionsResponse);
       expect(mockFetch).toHaveBeenCalledWith(
-        `${V2_URL}/traders/0x1234/positions/closed`,
+        `${V1_URL}/traders/0x1234/positions/closed`,
       );
     });
 

packages/social-controllers/src/SocialService.ts

@@ -69,6 +69,7 @@ const PositionStruct = structType({
   costBasis: number(),
   trades: array(TradeStruct),
   lastTradeAt: number(),
+  tokenImageUrl: optional(nullable(string())),
   currentValueUSD: optional(nullable(number())),
   pnlValueUsd: optional(nullable(number())),
   pnlPercent: optional(nullable(number())),
@@ -119,6 +120,7 @@ const TraderStatsStruct = structType({
   winRate7d: optional(nullable(number())),
   roiPercent7d: optional(nullable(number())),
   tradeCount7d: optional(nullable(number())),
+  medianHoldMinutes: optional(nullable(number())),
 });
 
 const PerChainBreakdownStruct = structType({
@@ -546,8 +548,9 @@ export class SocialService extends BaseDataService<
         page ?? null,
       ],
       queryFn: async () => {
+        const baseUrl = status === 'open' ? this.#v2Url : this.#v1Url;
         const url = new URL(
-          `${this.#v2Url}/traders/${encodeURIComponent(addressOrId)}/positions/${status}`,
+          `${baseUrl}/traders/${encodeURIComponent(addressOrId)}/positions/${status}`,
         );
         if (chain) {
           url.searchParams.append('chain', chain);

packages/social-controllers/src/social-types.ts

@@ -105,6 +105,8 @@ export type TraderStats = {
   winRate7d?: number | null;
   roiPercent7d?: number | null;
   tradeCount7d?: number | null;
+  /** Median holding time in minutes. */
+  medianHoldMinutes?: number | null;
 };
 
 export type PerChainBreakdown = {
@@ -142,6 +144,8 @@ export type Position = {
   costBasis: number;
   trades: Trade[];
   lastTradeAt: number;
+  /** Daylight-hosted token image URL. */
+  tokenImageUrl?: string | null;
   /** Current USD value of the remaining position (open positions only). */
   currentValueUSD?: number | null;
   /** Unrealized + realized PnL in USD. */