Skip to content

feat(STX-433): add submissionMethod to transaction metadata#8375

Merged
rarquevaux merged 2 commits into
mainfrom
feat/STX-433-metadata
Apr 7, 2026
Merged

feat(STX-433): add submissionMethod to transaction metadata#8375
rarquevaux merged 2 commits into
mainfrom
feat/STX-433-metadata

Conversation

@rarquevaux

@rarquevaux rarquevaux commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Explanation

The goal of this PR is to add a submissionMethod property in the TransactionMetadata object in order to record how the transaction was submitted to the network and add it to the metrics. This datapoint can be recording at submission in the https://github.com/MetaMask/metamask-extension/blob/main/app/scripts/controller-init/confirmations/transaction-controller-init.ts

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: this is a type-only change adding an optional metadata field and enum export, with no behavioral changes to transaction processing.

Overview
Adds an optional submissionMethod field to TransactionMeta along with a new TransactionSubmissionMethod enum (currently sentinel_stx and sentinel_relay) so clients can persist how a transaction was submitted.

Re-exports TransactionSubmissionMethod from the package entrypoint and documents the addition in the transaction-controller changelog.

Reviewed by Cursor Bugbot for commit dd12d37. Bugbot is set up for automated code reviews on this repo. Configure here.

@rarquevaux rarquevaux requested review from a team as code owners April 2, 2026 22:43
@rarquevaux rarquevaux force-pushed the feat/STX-433-metadata branch from 7b11078 to 221177a Compare April 2, 2026 23:15
/**
* The method used to submit the transaction to the network.
*/
submissionMethod?: TransactionSubmissionMethod;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sort alphabetically

@rarquevaux rarquevaux added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 0e12807 Apr 7, 2026
341 checks passed
@rarquevaux rarquevaux deleted the feat/STX-433-metadata branch April 7, 2026 15:03
rarquevaux added a commit that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants