fix: avoid fees in intent based swaps sent amount calculation#8845
Open
satyajeetkolhapure wants to merge 5 commits into
Open
fix: avoid fees in intent based swaps sent amount calculation#8845satyajeetkolhapure wants to merge 5 commits into
satyajeetkolhapure wants to merge 5 commits into
Conversation
satyajeetkolhapure
temporarily deployed
to
default-branch
GitHub Actions
Inactive
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Intent based swaps fees are already considered in sent amount. As the solvers take care of fees internally on provider side.
The current sent amount logic does add fees again in the calculation and shows larger amount than the actual amount sent.
This PR skips the fees from sent amount calculation logic resulting in correct amount.
References
Checklist
Note
Medium Risk
Adjusts user-facing sent amount calculations for intent-based swaps, which could affect displayed totals and any downstream logic that relies on
calcSentAmountoutputs. Change is localized and covered by a new unit test, but impacts monetary amounts.Overview
Fixes
calcSentAmountto skip addingfeeDatasource-token fees when a quote is intent-based (i.e., hasintent), preventing protocol fees from being double-counted in the sent amount.Adds a regression test for an intent-based quote scenario and updates the
bridge-controllerchangelog to document the fix.Reviewed by Cursor Bugbot for commit 4babdf8. Bugbot is set up for automated code reviews on this repo. Configure here.