Skip to content

Release 990.0.0#8848

Merged
matthewwalsh0 merged 3 commits into
mainfrom
release/990.0.0
May 19, 2026
Merged

Release 990.0.0#8848
matthewwalsh0 merged 3 commits into
mainfrom
release/990.0.0

Conversation

@matthewwalsh0
Copy link
Copy Markdown
Member

@matthewwalsh0 matthewwalsh0 commented May 19, 2026

Explanation

Release of:

  • @metamask/transaction-controller (major): 65.4.0 → 66.0.0
  • @metamask/bridge-status-controller (minor): 71.1.4 → 71.2.0
  • @metamask/transaction-pay-controller (minor): 22.5.0 → 22.6.0
  • @metamask/earn-controller (minor): 12.1.2 → 12.2.0
  • @metamask/perps-controller (minor): 6.1.0 → 6.2.0

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@matthewwalsh0 matthewwalsh0 marked this pull request as ready for review May 19, 2026 13:27
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners May 19, 2026 13:27
@matthewwalsh0 matthewwalsh0 enabled auto-merge May 19, 2026 13:28
@metamaskbotv2
Copy link
Copy Markdown

metamaskbotv2 Bot commented May 19, 2026

✅ No changelog changes needed.

@mcmire
Copy link
Copy Markdown
Contributor

mcmire commented May 19, 2026

@matthewwalsh0 To help with deduplicating the dependency tree in the clients, any thoughts on including the following dependents of transaction-controller in the release?

  • assets-controller
  • assets-controllers
  • bridge-controller
  • eip-5172-middleware
  • network-enablement-controller
  • phishing-controller
  • shield-controller
  • subscription-controller
  • user-operation-controller

It looks like all of these could be simple patch bumps.

(Skipping bridge-status-controller and transaction-pay-controller because they will likely be released soon anyway)

@matthewwalsh0
Copy link
Copy Markdown
Member Author

matthewwalsh0 commented May 19, 2026

@matthewwalsh0 To help with deduplicating the dependency tree in the clients, any thoughts on including the following dependents of transaction-controller in the release?

  • assets-controller
  • assets-controllers
  • bridge-controller
  • eip-5172-middleware
  • network-enablement-controller
  • phishing-controller
  • shield-controller
  • subscription-controller
  • user-operation-controller

It looks like all of these could be simple patch bumps.

(Skipping bridge-status-controller and transaction-pay-controller because they will likely be released soon anyway)

I wouldn't usually since we usually aim to release the minimum scope we can be confident is ready for release, and not take on any additional obligations or assumptions. But in this instance, you're correct we should release those ones that use the new isInternal or their behaviour will change in the client when we bump transaction controller.

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue May 19, 2026
@FrederikBolding FrederikBolding removed this pull request from the merge queue due to a manual request May 19, 2026
@FrederikBolding
Copy link
Copy Markdown
Member

Just pulling this out of the merge queue in case you want to address Elliot's comment.

@matthewwalsh0 matthewwalsh0 enabled auto-merge May 19, 2026 14:53
Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 89ffb46 May 19, 2026
735 of 747 checks passed
@matthewwalsh0 matthewwalsh0 deleted the release/990.0.0 branch May 19, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants