fix(account-tree-controller): add support for new (v2) KeyringType#8885
Open
ccharly wants to merge 4 commits into
Open
fix(account-tree-controller): add support for new (v2) KeyringType#8885ccharly wants to merge 4 commits into
KeyringType#8885ccharly wants to merge 4 commits into
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
ccharly
changed the title
KeyringType
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
hmalik88
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
We are integrating new keyring v2 slowly. So the group naming will have to support this.
This is required at least for the Snap keyring v2 support that will be seen as "real keyrings" (different from v2 wrappers).
References
N/A
Checklist
Note
Medium Risk
Moderate risk because it changes account grouping/naming logic and Snap account detection, which can affect how wallets/groups are organized in clients if keyring types are misidentified.
Overview
Updates account-tree keyring naming helpers to accept both legacy
KeyringTypesand new v2KeyringType, mapping v2 values to the same wallet/group display names.Extends
SnapRulematching to treatKeyringType.Snapaccounts as Snap accounts (in addition toKeyringTypes.snap) and adds tests/fixtures covering v2 Snap accounts, blocked snaps, and unknown keyring types; also records the change in the package changelog and removes an obsolete ESLint suppression entry.Reviewed by Cursor Bugbot for commit 855431b. Bugbot is set up for automated code reviews on this repo. Configure here.