chore: mark cancelled-STX failure change as breaking#9420
Merged
Conversation
The #9400 change swaps the smart transactions controller's messenger requirement from TransactionController:updateTransaction to TransactionController:failTransaction. Adding/removing a required allowed action is a breaking change for consumers (they must delegate the new action to the controller messenger), so recategorize the entry from Fixed to Changed with a BREAKING marker. This ensures the package is released as a major version bump.
cloudonshore
temporarily deployed
to
default-branch
GitHub Actions
Inactive
cryptodev-2s
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Follow-up to #9400 (already merged). That PR changed the
smart-transactions-controllermessenger requirement fromTransactionController:updateTransactiontoTransactionController:failTransaction. Adding/removing a required allowed action is a breaking change for consumers — they must delegate the new action to the controller messenger on the client side (extension/mobile) or they get a type error.The changelog entry was filed under
### Fixed, which would have the package cut as a patch release and silently break consumers on upgrade. This recategorizes it under### Changedwith a**BREAKING:**marker so the next release is correctly a major version bump (24.2.4→25.0.0), consistent with how allowed-action changes are documented elsewhere in the monorepo (e.g.AssetsControllerMessenger now requires ...in assets-controller,NftController allowed actionsin assets-controllers).No code changes — changelog only.
References
Changelog
@metamask/smart-transactions-controllerFixedtoChangedand marked itBREAKING; no functional change.Checklist
Note
Low Risk
Documentation-only changelog edit with no code, tests, or runtime behavior changes.
Overview
Updates
@metamask/smart-transactions-controllerUnreleased changelog only: the #9400 note about usingTransactionController:failTransactioninstead ofTransactionController:updateTransactionwhen a smart transaction is cancelled moves from### Fixedto### Changedand is labeledBREAKING:, with explicit guidance that consumers must delegate the new allowed action.The separate
### Fixedsection is removed and the@metamask/messengerbump stays under### Changed. No runtime or API code changes in this PR—only semver/documentation so the next release is treated as major for the messenger requirement change from #9400.Reviewed by Cursor Bugbot for commit 3bdac95. Bugbot is set up for automated code reviews on this repo. Configure here.