Skip to content

Commit 0b4fb83

Browse files
committed
Loosen promise/catch-or-return and promise/param-names rules
1 parent 3276a93 commit 0b4fb83

2 files changed

Lines changed: 19 additions & 3 deletions

File tree

packages/base/rules-snapshot.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3248,15 +3248,18 @@
32483248
],
32493249
"promise/always-return": "error",
32503250
"promise/avoid-new": "off",
3251-
"promise/catch-or-return": "error",
3251+
"promise/catch-or-return": ["error", { "allowFinally": true }],
32523252
"promise/no-callback-in-promise": "warn",
32533253
"promise/no-native": "off",
32543254
"promise/no-nesting": "warn",
32553255
"promise/no-new-statics": "error",
32563256
"promise/no-promise-in-callback": "warn",
32573257
"promise/no-return-in-finally": "warn",
32583258
"promise/no-return-wrap": "error",
3259-
"promise/param-names": "error",
3259+
"promise/param-names": [
3260+
"error",
3261+
{ "resolvePattern": "^_?resolve", "rejectPattern": "^_?reject" }
3262+
],
32603263
"promise/valid-params": "warn",
32613264
"quote-props": "off",
32623265
"quotes": "off",

packages/base/src/index.mjs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,20 @@ const rules = createConfig({
417417
],
418418
'jsdoc/valid-types': 'error',
419419

420-
// 'promise/no-multiple-resolved': 'error',
420+
/* promise plugin rules */
421+
'promise/catch-or-return': [
422+
'error',
423+
{
424+
allowFinally: true,
425+
},
426+
],
427+
'promise/param-names': [
428+
'error',
429+
{
430+
resolvePattern: '^_?resolve',
431+
rejectPattern: '^_?reject',
432+
},
433+
],
421434
},
422435
});
423436

0 commit comments

Comments
 (0)