chore(7107): Include a Sentry Explore Link in the Announcement

Author: DDDDDanica

development/lint-changed.mts

@@ -53,6 +53,36 @@ function getChangedFileNames(): string[] {
   return [...unique];
 }
 
+/**
+ * Paths can appear in git output but not exist on disk (e.g. staged add + working-tree
+ * delete shows as `AD`). ESLint fails on missing paths; skip those.
+ */
+function filterToExistingFiles(files: string[]): string[] {
+  const existing: string[] = [];
+  const missing: string[] = [];
+
+  for (const file of files) {
+    const absolute = path.join(process.cwd(), file);
+    if (fs.existsSync(absolute)) {
+      existing.push(file);
+    } else {
+      missing.push(file);
+    }
+  }
+
+  if (missing.length > 0) {
+    process.stderr.write(
+      `Skipping ${missing.length} changed path(s) not found on disk (fix git state, e.g. restore files or git rm --cached):\n`,
+    );
+    for (const file of missing) {
+      process.stderr.write(`  - ${file}\n`);
+    }
+    process.stderr.write('\n');
+  }
+
+  return existing;
+}
+
 function parseArgs(argv: string[]): LintChangedOptions {
   return {
     fix: argv.includes('--fix'),
@@ -100,8 +130,8 @@ function chunkByApproxCommandLength(
 function main(): void {
   const options = parseArgs(process.argv.slice(2));
 
-  const changedFiles = getChangedFileNames().filter((file) =>
-    JS_TS_TSX_SNAP_FILE_REGEX.test(file),
+  const changedFiles = filterToExistingFiles(
+    getChangedFileNames().filter((file) => JS_TS_TSX_SNAP_FILE_REGEX.test(file)),
   );
 
   if (changedFiles.length === 0) {

development/metamaskbot-build-announce/compare-benchmarks.test.ts

@@ -47,7 +47,7 @@ describe('compare-benchmarks', () => {
     it('passes when results are within thresholds', () => {
       const benchmarks = [
         {
-          name: 'benchmark-chrome-browserify-userJourneyOnboardingImport',
+          name: 'benchmark-chrome-webpack-userJourneyOnboardingImport',
           data: {
             onboardingImportWallet: makeBenchmarkResults({
               p75: { importWalletToSocialScreen: 1500 },
@@ -66,7 +66,7 @@ describe('compare-benchmarks', () => {
     it('fails when p75 exceeds fail threshold', () => {
       const benchmarks = [
         {
-          name: 'benchmark-chrome-browserify-userJourneyOnboardingImport',
+          name: 'benchmark-chrome-webpack-userJourneyOnboardingImport',
           data: {
             onboardingImportWallet: makeBenchmarkResults({
               p75: { importWalletToSocialScreen: 99999 },
@@ -84,7 +84,7 @@ describe('compare-benchmarks', () => {
     it('includes relative metrics when baseline is available', () => {
       const benchmarks = [
         {
-          name: 'benchmark-chrome-browserify-userJourneyOnboardingImport',
+          name: 'benchmark-chrome-webpack-userJourneyOnboardingImport',
           data: {
             onboardingImportWallet: makeBenchmarkResults({
               p75: { importWalletToSocialScreen: 1500 },
@@ -124,7 +124,7 @@ describe('compare-benchmarks', () => {
     it('resolves page-load baseline for startup benchmarks', () => {
       const benchmarks = [
         {
-          name: 'benchmark-chrome-browserify-startupStandardHome',
+          name: 'benchmark-chrome-webpack-startupStandardHome',
           data: {
             startupStandardHome: makeBenchmarkResults({
               p75: { uiStartup: 1800 },

development/metamaskbot-build-announce/comparison-utils.test.ts

@@ -366,12 +366,10 @@ describe('THRESHOLD_REGISTRY', () => {
     expect(THRESHOLD_REGISTRY.loadNewAccount).toBeDefined();
     expect(THRESHOLD_REGISTRY.confirmTx).toBeDefined();
     expect(THRESHOLD_REGISTRY.bridgeUserActions).toBeDefined();
-    expect(
-      THRESHOLD_REGISTRY['chrome-browserify-loadNewAccount'],
-    ).toBeUndefined();
+    expect(THRESHOLD_REGISTRY['chrome-webpack-loadNewAccount']).toBeUndefined();
   });
 
-  it('has platform-agnostic keys for user journey (chrome-browserify + chrome-webpack)', () => {
+  it('has platform-agnostic keys for user journey (no per-platform threshold keys)', () => {
     expect(THRESHOLD_REGISTRY.onboardingImportWallet).toBeDefined();
     expect(THRESHOLD_REGISTRY.swap).toBeDefined();
     expect(THRESHOLD_REGISTRY['chrome-webpack-swap']).toBeUndefined();
@@ -381,7 +379,7 @@ describe('THRESHOLD_REGISTRY', () => {
     expect(THRESHOLD_REGISTRY.startupStandardHome).toBeDefined();
     expect(THRESHOLD_REGISTRY.startupPowerUserHome).toBeDefined();
     expect(
-      THRESHOLD_REGISTRY['chrome-browserify-startupStandardHome'],
+      THRESHOLD_REGISTRY['chrome-webpack-startupStandardHome'],
     ).toBeUndefined();
     expect(
       THRESHOLD_REGISTRY['firefox-webpack-startupPowerUserHome'],

development/metamaskbot-build-announce/performance-benchmarks.ts

@@ -46,6 +46,7 @@ import {
   buildArtifactFilename,
   buildArtifactUrl,
 } from './utils';
+import { buildSentryLogsUrl } from './sentry-utils';
 
 export type BenchmarkEntry = {
   benchmarkName: string;
@@ -476,6 +477,53 @@ function extractDisplayName(benchmarkName: string): string {
   return match ? match[1] : benchmarkName;
 }
 
+/**
+ * Builds HTML for an artifact log link and optional Sentry Logs Explorer link.
+ *
+ * @param logHref - Optional artifact log URL
+ * @param entry - Benchmark entry (for Sentry filters)
+ * @param logLinkInnerHtml - Inner HTML for the artifact log anchor (e.g. '[Show logs]')
+ */
+function buildArtifactAndSentryLinksHtml(
+  logHref: string | undefined,
+  entry: BenchmarkEntry | undefined,
+  logLinkInnerHtml: string,
+): string {
+  const branchName = process.env.BRANCH || process.env.GITHUB_REF_NAME;
+  const sentryUrl =
+    branchName && entry
+      ? buildSentryLogsUrl(branchName, undefined, {
+          browser: entry.platform,
+          buildType: entry.buildType,
+          benchmarkName: entry.benchmarkName,
+        })
+      : null;
+
+  const logsLink = logHref
+    ? `<a href="${logHref}">${logLinkInnerHtml}</a>`
+    : '';
+  const sentryLinkHtml = sentryUrl
+    ? `<a href="${sentryUrl}">[Sentry log]</a>`
+    : '';
+
+  return [logsLink, sentryLinkHtml].filter(Boolean).join(' ');
+}
+
+/**
+ * Builds table cell content with health icon and links (CI artifact + Sentry).
+ * @param icon
+ * @param logHref
+ * @param entry
+ */
+function buildCellContent(
+  icon: string,
+  logHref: string | undefined,
+  entry: BenchmarkEntry | undefined,
+): string {
+  const links = buildArtifactAndSentryLinksHtml(logHref, entry, '[Show logs]');
+  return links ? `${icon} ${links}` : icon;
+}
+
 /**
  * Counts the number of failing and warning benchmark entries.
  *
@@ -561,9 +609,12 @@ function formatTimerDetails(
         return null;
       }
 
-      const logsLine = logHref
-        ? `<br><a href="${logHref}">[Show logs]</a>`
-        : '';
+      const linksHtml = buildArtifactAndSentryLinksHtml(
+        logHref,
+        entry,
+        '[Show logs]',
+      );
+      const logsLine = linksHtml ? `<br>${linksHtml}` : '';
       return `<div>${icon} <code>${metricName}</code>${logsLine}</div>`;
     })
     .filter((item) => item !== null)
@@ -813,17 +864,13 @@ export function buildBenchmarkSection(
                 logHref,
               );
 
-              const logsLink = logHref
-                ? `<a href="${logHref}">[Show logs]</a>`
-                : '';
-
               let cell: string;
               switch (true) {
                 case Boolean(timerDetails):
                   cell = timerDetails;
                   break;
                 case Boolean(logHref):
-                  cell = `${icon} ${logsLink}`;
+                  cell = buildCellContent(icon, logHref, entry);
                   break;
                 default:
                   cell = icon;
@@ -943,9 +990,12 @@ function buildHealthMatrixHtml(
           );
           const logHref = entry?.artifactUrl;
           const label = data.label ? `${icon} ${data.label}` : icon;
-          const cell = logHref
-            ? `${label} <a href="${logHref}">[logs]</a>`
-            : label;
+          const links = buildArtifactAndSentryLinksHtml(
+            logHref,
+            entry,
+            '[logs]',
+          );
+          const cell = links ? `${label} ${links}` : label;
           return `<td align="center">${cell}</td>`;
         })
         .join('');
@@ -1030,7 +1080,12 @@ function buildFailingItemsHtml(
       const worstLabel = getWorstViolationLabel(entry, baselineMetrics);
       const labelPart = worstLabel ? ` — ${worstLabel}` : '';
       const logHref = entry.artifactUrl ?? runUrl;
-      const logAnchor = logHref ? ` <a href="${logHref}">[Show logs]</a>` : '';
+      const links = buildArtifactAndSentryLinksHtml(
+        logHref,
+        entry,
+        '[Show logs]',
+      );
+      const logAnchor = links ? ` ${links}` : '';
       return [
         `<li><b>${entry.benchmarkName}</b> · ${entry.platform}-${entry.buildType}${labelPart}${logAnchor}</li>`,
       ];

development/metamaskbot-build-announce/sentry-utils.test.ts

@@ -0,0 +1,133 @@
+import { parseSentryDSN, buildSentryLogsUrl } from './sentry-utils';
+
+describe('parseSentryDSN', () => {
+  it('parses standard Sentry DSN format', () => {
+    const dsn = 'https://fake@metamask.sentry.io/4510302346608640';
+    const result = parseSentryDSN(dsn);
+
+    expect(result).toStrictEqual({
+      organization: 'metamask',
+      projectId: '4510302346608640',
+    });
+  });
+
+  it('parses ingest subdomain format', () => {
+    const dsn = 'https://key@org.ingest.sentry.io/123456';
+    const result = parseSentryDSN(dsn);
+
+    expect(result).toStrictEqual({
+      organization: 'org',
+      projectId: '123456',
+    });
+  });
+
+  it('returns null for invalid URL', () => {
+    const dsn = 'not-a-valid-url';
+    const result = parseSentryDSN(dsn);
+
+    expect(result).toBeNull();
+  });
+
+  it('returns null for non-sentry.io hostname', () => {
+    const dsn = 'https://key@example.com/123';
+    const result = parseSentryDSN(dsn);
+
+    expect(result).toBeNull();
+  });
+
+  it('returns null when project ID is missing', () => {
+    const dsn = 'https://key@metamask.sentry.io/';
+    const result = parseSentryDSN(dsn);
+
+    expect(result).toBeNull();
+  });
+});
+
+describe('buildSentryLogsUrl', () => {
+  const mockDsn = 'https://fake@metamask.sentry.io/4510302346608640';
+
+  beforeEach(() => {
+    delete process.env.SENTRY_DSN_PERFORMANCE;
+  });
+
+  afterEach(() => {
+    delete process.env.SENTRY_DSN_PERFORMANCE;
+  });
+
+  it('builds Sentry Logs Explorer URL with branch filter', () => {
+    const url = buildSentryLogsUrl('feat/my-branch', mockDsn);
+
+    expect(url).toContain('https://metamask.sentry.io/explore/logs/');
+    expect(url).toContain('logsQuery=ci.branch%3Afeat%2Fmy-branch');
+    expect(url).toContain('project=4510302346608640');
+    expect(url).toContain('statsPeriod=2w');
+    expect(url).toContain('logsSortBys=-timestamp');
+    expect(url).toContain('logsFields=timestamp');
+    expect(url).toContain('logsFields=message');
+  });
+
+  it('uses SENTRY_DSN_PERFORMANCE env var when DSN not provided', () => {
+    process.env.SENTRY_DSN_PERFORMANCE = mockDsn;
+
+    const url = buildSentryLogsUrl('main');
+
+    expect(url).toContain('logsQuery=ci.branch%3Amain');
+  });
+
+  it('returns null when DSN is not provided and env var not set', () => {
+    const url = buildSentryLogsUrl('main');
+
+    expect(url).toBeNull();
+  });
+
+  it('returns null when DSN is invalid', () => {
+    const url = buildSentryLogsUrl('main', 'invalid-dsn');
+
+    expect(url).toBeNull();
+  });
+
+  it('handles branch names with special characters', () => {
+    const url = buildSentryLogsUrl('feature/add-new-thing', mockDsn);
+
+    expect(url).toContain('logsQuery=ci.branch%3Afeature%2Fadd-new-thing');
+  });
+
+  it('includes browser filter when provided', () => {
+    const url = buildSentryLogsUrl('main', mockDsn, { browser: 'chrome' });
+
+    expect(url).toContain('ci.branch%3Amain');
+    expect(url).toContain('ci.browser%3Achrome');
+  });
+
+  it('includes buildType filter when provided', () => {
+    const url = buildSentryLogsUrl('main', mockDsn, {
+      buildType: 'browserify',
+    });
+
+    expect(url).toContain('ci.buildType%3Abrowserify');
+  });
+
+  it('includes benchmark name filter with message:Contains format', () => {
+    const url = buildSentryLogsUrl('main', mockDsn, {
+      benchmarkName: 'firefox-browserify-startupStandardHome',
+    });
+
+    expect(url).toContain('message');
+    expect(url).toContain('Contains');
+    expect(url).toContain('benchmark.firefox-browserify-startupStandardHome');
+  });
+
+  it('combines all filters when all options provided', () => {
+    const url = buildSentryLogsUrl('feat/test', mockDsn, {
+      browser: 'firefox',
+      buildType: 'webpack',
+      benchmarkName: 'test-benchmark',
+    });
+
+    expect(url).toContain('ci.branch%3Afeat%2Ftest');
+    expect(url).toContain('ci.browser%3Afirefox');
+    expect(url).toContain('ci.buildType%3Awebpack');
+    expect(url).toContain('message');
+    expect(url).toContain('benchmark.test-benchmark');
+  });
+});