Skip to content

Commit 93a865c

Browse files
jeffsmale90jeffsmale90
committed
Fix unit tests
1 parent aa168a3 commit 93a865c

3 files changed

Lines changed: 43 additions & 37 deletions

File tree

‎ui/components/multichain/pages/gator-permissions/components/__snapshots__/review-gator-permission-item.test.tsx.snap‎

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ exports[`Permission List Item render ERC20 token permissions renders erc20 token
397397
</div>
398398
`;
399399

400-
exports[`Permission List Item render ERC20 token permissions renders erc20 token revocation permission correctly without frequency row 1`] = `
400+
exports[`Permission List Item render ERC20 token permissions renders erc20 token stream permission correctly 1`] = `
401401
<div>
402402
<div
403403
class="box box--margin-4 box--padding-4 box--gap-1 box--flex-direction-row box--background-color-background-default box--rounded-md box--border-style-solid box--border-color-border-muted box--border-width-1"
@@ -444,7 +444,7 @@ exports[`Permission List Item render ERC20 token permissions renders erc20 token
444444
<p
445445
class="text-alternative text-s-body-md leading-s-body-md tracking-s-body-md md:text-l-body-md md:leading-l-body-md md:tracking-l-body-md font-regular font-default text-left"
446446
>
447-
Revoke token approvals
447+
Streaming amount
448448
</p>
449449
<div
450450
class="flex flex-row gap-2 items-center justify-end"
@@ -454,7 +454,28 @@ exports[`Permission List Item render ERC20 token permissions renders erc20 token
454454
class="text-alternative text-s-body-md leading-s-body-md tracking-s-body-md md:text-l-body-md md:leading-l-body-md md:tracking-l-body-md font-regular font-default text-right"
455455
data-testid="review-gator-permission-amount-label"
456456
>
457-
All tokens
457+
302400 WBTC
458+
</p>
459+
</div>
460+
</div>
461+
<div
462+
class="flex flex-row gap-4 justify-between mt-2"
463+
style="flex: 1; align-self: center;"
464+
>
465+
<p
466+
class="text-alternative text-s-body-md leading-s-body-md tracking-s-body-md md:text-l-body-md md:leading-l-body-md md:tracking-l-body-md font-regular font-default text-left"
467+
>
468+
Period
469+
</p>
470+
<div
471+
class="flex flex-row gap-2 items-center justify-end"
472+
style="flex: 1; align-self: center;"
473+
>
474+
<p
475+
class="text-alternative text-s-body-md leading-s-body-md tracking-s-body-md md:text-l-body-md md:leading-l-body-md md:tracking-l-body-md font-regular font-default text-right"
476+
data-testid="review-gator-permission-frequency-label"
477+
>
478+
Weekly
458479
</p>
459480
</div>
460481
</div>
@@ -572,7 +593,7 @@ exports[`Permission List Item render ERC20 token permissions renders erc20 token
572593
</div>
573594
`;
574595

575-
exports[`Permission List Item render ERC20 token permissions renders erc20 token stream permission correctly 1`] = `
596+
exports[`Permission List Item render ERC20 token permissions renders token approval revocation permission correctly without frequency row 1`] = `
576597
<div>
577598
<div
578599
class="box box--margin-4 box--padding-4 box--gap-1 box--flex-direction-row box--background-color-background-default box--rounded-md box--border-style-solid box--border-color-border-muted box--border-width-1"
@@ -619,7 +640,7 @@ exports[`Permission List Item render ERC20 token permissions renders erc20 token
619640
<p
620641
class="text-alternative text-s-body-md leading-s-body-md tracking-s-body-md md:text-l-body-md md:leading-l-body-md md:tracking-l-body-md font-regular font-default text-left"
621642
>
622-
Streaming amount
643+
Revoke token approvals
623644
</p>
624645
<div
625646
class="flex flex-row gap-2 items-center justify-end"
@@ -629,28 +650,7 @@ exports[`Permission List Item render ERC20 token permissions renders erc20 token
629650
class="text-alternative text-s-body-md leading-s-body-md tracking-s-body-md md:text-l-body-md md:leading-l-body-md md:tracking-l-body-md font-regular font-default text-right"
630651
data-testid="review-gator-permission-amount-label"
631652
>
632-
302400 WBTC
633-
</p>
634-
</div>
635-
</div>
636-
<div
637-
class="flex flex-row gap-4 justify-between mt-2"
638-
style="flex: 1; align-self: center;"
639-
>
640-
<p
641-
class="text-alternative text-s-body-md leading-s-body-md tracking-s-body-md md:text-l-body-md md:leading-l-body-md md:tracking-l-body-md font-regular font-default text-left"
642-
>
643-
Period
644-
</p>
645-
<div
646-
class="flex flex-row gap-2 items-center justify-end"
647-
style="flex: 1; align-self: center;"
648-
>
649-
<p
650-
class="text-alternative text-s-body-md leading-s-body-md tracking-s-body-md md:text-l-body-md md:leading-l-body-md md:tracking-l-body-md font-regular font-default text-right"
651-
data-testid="review-gator-permission-frequency-label"
652-
>
653-
Weekly
653+
All tokens
654654
</p>
655655
</div>
656656
</div>

‎ui/components/multichain/pages/gator-permissions/components/review-gator-permission-item.test.tsx‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import configureStore from '../../../../../store/store';
1717
import mockState from '../../../../../../test/data/mock-state.json';
1818
import { getPendingRevocations } from '../../../../../selectors/gator-permissions/gator-permissions';
1919
import { ReviewGatorPermissionItem } from './review-gator-permission-item';
20+
import { TokenApprovalRevocationPermission } from '@metamask/7715-permission-types';
2021

2122
const mockAccountAddress = '0x4f71DA06987BfeDE90aF0b33E1e3e4ffDCEE7a63';
2223
const mockAccountName = 'Test Gator Account';
@@ -804,11 +805,7 @@ describe('Permission List Item', () => {
804805
});
805806

806807
it('renders token approval revocation permission correctly without frequency row', () => {
807-
const mockErc20TokenRevocationPermission: PermissionInfoWithMetadata<{
808-
type: 'token-approval-revocation';
809-
isAdjustmentAllowed: boolean;
810-
data: Record<string, unknown>;
811-
}> = {
808+
const mockErc20TokenRevocationPermission: PermissionInfoWithMetadata<TokenApprovalRevocationPermission> = {
812809
permissionResponse: {
813810
chainId: '0x1',
814811
from: mockAccountAddress,

‎ui/pages/confirmations/components/confirm/info/typed-sign/typed-sign-permission/permission-detail-renderer.test.tsx‎

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -372,13 +372,16 @@ describe('PermissionDetailRenderer', () => {
372372
).toBeInTheDocument();
373373
});
374374

375-
it('renders the all-primitives text when only ERC primitives are enabled', () => {
375+
it('renders the all-primitives text when all revocation primitives are enabled', () => {
376376
const permission = {
377377
type: 'token-approval-revocation',
378378
data: {
379379
erc20Approve: true,
380380
erc721Approve: true,
381381
erc721SetApprovalForAll: true,
382+
permit2Approve: true,
383+
permit2Lockdown: true,
384+
permit2InvalidateNonces: true,
382385
},
383386
};
384387
const { getByText, queryByText } = renderWithConfirmContextProvider(
@@ -393,9 +396,13 @@ describe('PermissionDetailRenderer', () => {
393396
);
394397

395398
expect(
396-
getByText('All revocation primitives for ERC-20, ERC-1155, ERC-721.'),
399+
getByText(
400+
messages.gatorPermissionsAllTokenApprovalRevocationPrimitives.message,
401+
),
397402
).toBeInTheDocument();
398-
expect(queryByText('ERC-20 approve(spender, 0)')).not.toBeInTheDocument();
403+
expect(
404+
queryByText(messages.gatorPermissionsErc20ApproveRevocation.message),
405+
).not.toBeInTheDocument();
399406
});
400407

401408
it('renders the revocation method list when non-primitive methods are enabled', () => {
@@ -420,10 +427,12 @@ describe('PermissionDetailRenderer', () => {
420427
);
421428

422429
expect(
423-
getByText('Permit2 approve(token, spender, 0, 0)'),
430+
getByText(messages.gatorPermissionsPermit2ApproveRevocation.message),
424431
).toBeInTheDocument();
425432
expect(
426-
queryByText('All revocation primitives for ERC-20, ERC-1155, ERC-721.'),
433+
queryByText(
434+
messages.gatorPermissionsAllTokenApprovalRevocationPrimitives.message,
435+
),
427436
).not.toBeInTheDocument();
428437
});
429438
});

0 commit comments

Comments
 (0)