Fixed lint and formatting

Author: davibroc

test/e2e/page-objects/pages/bridge/quote-page.ts

@@ -73,6 +73,16 @@ class BridgeQuotePage {
   private networkNameSelector = (network: string) =>
     `[data-testid="${network}"]`;
 
+  private transactionComplete = {
+    tag: 'h4',
+    text: 'Your transaction is complete',
+  };
+
+  private transactionFailed = { tag: 'h4', text: 'Your transaction failed' };
+
+  private closeButton =
+    '[data-testid="smart-transaction-status-page-footer-close-button"]';
+
   constructor(driver: Driver) {
     this.driver = driver;
   }
@@ -226,33 +236,21 @@ class BridgeQuotePage {
 
   checkTransactionCompleteAndViewActivity = async () => {
     console.log('Waiting for transaction complete modal');
-    await this.driver.waitForSelector(
-      {
-        css: 'h4',
-        text: 'Your transaction is complete',
-      },
-      { timeout: 30000 },
-    );
+    await this.driver.waitForSelector(this.transactionComplete, {
+      timeout: 60000,
+    });
     console.log('Transaction complete modal is displayed');
-    await this.driver.clickElement(
-      '[data-testid="smart-transaction-status-page-footer-close-button"]',
-    );
+    await this.driver.clickElement(this.closeButton);
     console.log('Clicked View activity button');
   };
 
   checkTransactionFailedAndViewActivity = async () => {
     console.log('Waiting for transaction failed modal');
-    await this.driver.waitForSelector(
-      {
-        css: 'h4',
-        text: 'Your transaction failed',
-      },
-      { timeout: 30000 },
-    );
+    await this.driver.waitForSelector(this.transactionFailed, {
+      timeout: 60000,
+    });
     console.log('Transaction failed modal is displayed');
-    await this.driver.clickElement(
-      '[data-testid="smart-transaction-status-page-footer-close-button"]',
-    );
+    await this.driver.clickElement(this.closeButton);
     console.log('Clicked View activity button');
   };
 

test/e2e/tests/bridge/bridge-L2-tests.spec.ts

@@ -8,7 +8,11 @@ describe('Bridge tests', function (this: Suite) {
   this.timeout(120000); // Needs a higher timeout as it's a longer tests
   it('should execute bridge transactions on L2 networks', async function () {
     await withFixtures(
-      getBridgeL2Fixtures(this.test?.fullTitle(), BRIDGE_FEATURE_FLAGS_WITH_SSE_ENABLED, true),
+      getBridgeL2Fixtures(
+        this.test?.fullTitle(),
+        BRIDGE_FEATURE_FLAGS_WITH_SSE_ENABLED,
+        true,
+      ),
       async ({ driver }) => {
         await login(driver, { expectedBalance: '$225,730.11' });
 

test/e2e/tests/bridge/bridge-test-utils.ts

@@ -102,6 +102,7 @@ export class BridgePage {
  * @param testParams.expectedDestAmount - The expected quoted destination amounts in the quote page
  * @param testParams.submitDelay - The delay to wait before submitting the transaction, must be less than the refresh interval of the stream
  * @param testParams.expectedStatus - The expected state of the transaction
+ * @param testParams.withSmartTransactions
  */
 export const bridgeTransaction = async ({
   driver,
@@ -142,6 +143,8 @@ export const bridgeTransaction = async ({
 
   if (withSmartTransactions) {
     await bridgePage.checkTransactionCompleteAndViewActivity();
+  } else {
+    await homePage.goToActivityList();
   }
 
   const activityList = new ActivityListPage(driver);
@@ -544,7 +547,7 @@ const emitLine = (controller: ReadableStreamDefaultController, line: string) =>
  * @param delay - The delay to wait between emitting each quote
  * @returns The Readable stream
  */
-const mockSseEventSource = (mockQuotes: unknown[], delay: number = 2000) => {
+function mockSseEventSource(mockQuotes: unknown[], delay: number = 2000) {
   let index = 0;
   return Readable.fromWeb(
     new ReadableStreamWeb({
@@ -561,7 +564,7 @@ const mockSseEventSource = (mockQuotes: unknown[], delay: number = 2000) => {
       },
     }),
   );
-};
+}
 
 async function mockFeatureFlags(
   mockServer: Mockttp,
@@ -575,7 +578,11 @@ async function mockFeatureFlags(
         ok: true,
         statusCode: 200,
         json: [
-          { bridgeConfig: featureFlags, extensionUxPna25: true, ...additionalFlags },
+          {
+            bridgeConfig: featureFlags,
+            extensionUxPna25: true,
+            ...additionalFlags,
+          },
         ],
       };
     });
@@ -1064,6 +1071,10 @@ const STX_TRANSACTION_HASH =
  * via eth_sendRawTransaction. Anvil mines it immediately, so the real tx hash is
  * on-chain and eth_getTransactionReceipt returns a genuine receipt — which is what
  * the extension's TransactionController needs to mark the transaction as Confirmed.
+ * @param mockServer
+ * @param chainId
+ * @param sentinelUrl
+ * @param batchStatusOverride
  */
 async function mockSmartTransactionsForBridge(
   mockServer: Mockttp,
@@ -1420,7 +1431,11 @@ export const getQuoteNegativeCasesFixtures = (
     testSpecificMock: async (mockServer: Mockttp) => {
       const mocks = [
         await mockTopAssetsLinea(mockServer),
-        await mockGetQuoteInvalid(mockServer, options, featureFlags.sse?.enabled),
+        await mockGetQuoteInvalid(
+          mockServer,
+          options,
+          featureFlags.sse?.enabled,
+        ),
         await mockTokensLinea(mockServer),
         await mockGetPopularTokens(mockServer),
         await mockPriceSpotPrices(mockServer),
@@ -1776,7 +1791,11 @@ export const getBridgeL2Fixtures = (
       mocks.push(...(await mockSearchTokens(mockServer)));
 
       if (withSmartTransactions) {
-        await mockSmartTransactionsForBridge(mockServer, 59144, LINEA_SENTINEL_URL);
+        await mockSmartTransactionsForBridge(
+          mockServer,
+          59144,
+          LINEA_SENTINEL_URL,
+        );
       }
 
       return mocks.filter(Boolean);

test/e2e/tests/smart-transactions/mocks.ts

@@ -705,7 +705,9 @@ export async function mockSmartTransactionBatchRequests(
   }
 }
 
-export async function mockSmartTransactionRequestsBase(mockServer: MockttpServer) {
+export async function mockSmartTransactionRequestsBase(
+  mockServer: MockttpServer,
+) {
   await mockMultiNetworkBalancePolling(mockServer);
 
   await mockServerJsonRpc(mockServer, [