feat(STX-331): replace legacy STX swaps flags with smart transaction flags from remote config API#38572
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +10 -10)
📜 @MetaMask/policy-reviewers (6 files, +27 -5)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔄 @MetaMask/swaps-engineers (2 files, +21 -21)
💸 @MetaMask/transactions (4 files, +109 -303)
|
af7b80f to
a940b01
Compare
a940b01 to
240a093
Compare
daad80d to
390d595
Compare
1ee27ad to
d93fcd9
Compare
c25644a to
9f1fa5a
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Builds ready [9f1fa5a]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [51098ea]
UI Startup Metrics (1280 ± 111 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [874d7dc]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [952321d]
UI Startup Metrics (1290 ± 100 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
1 similar comment
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
|
No policy changes |
Builds ready [e74ad93]
UI Startup Metrics (1305 ± 102 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Builds ready [8f9be19]
UI Startup Metrics (1259 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
@metamaskbot update-policies |
|
No policy changes |
Builds ready [343e69c]
UI Startup Metrics (1355 ± 122 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d022116]
UI Startup Metrics (1310 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [31fbffc]
UI Startup Metrics (1285 ± 110 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
hjetpoluru
left a comment
There was a problem hiding this comment.
Reviewed e2e related files and lgtm
…flags from remote config API
hjetpoluru
left a comment
There was a problem hiding this comment.
Automation e2e file changes lgtm
Builds ready [d67bdba]
UI Startup Metrics (1266 ± 103 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
left a comment
There was a problem hiding this comment.
Policy changes look good.
Package access added for internal libraries, lodash, reselect.
Description
Upgrades
@metamask/smart-transactions-controllerand consolidates feature flag logic by delegating to the controller's built-in selector (selectSmartTransactionsFeatureFlagsForChain).Key changes:
getSmartTransactionsFeatureFlagsForChainto wrap the controller's selector, which handles validation and merging of default + chain-specific configThis removes the usage of the smart-transactions section of the swaps feature flags. No functional changes are expected.
Changelog
CHANGELOG entry: upgrade smart-transactions-controller and replace the legacy smart transactions swaps flag with smart transactions flag from remote config API.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Consolidates Smart Transactions feature flags to Remote Feature Flags and adopts the controller’s selector, removing legacy swaps-based flags.
selectSmartTransactionsFeatureFlagsForChain; addgetSmartTransactionsFeatureFlagsForChainwrapper; remove oldfeature-flagsselector usageextensionReturnTxHashAsap,batchStatusPollingInterval) and simplifygetSmartTransactionCommonParams; drop unused hardware-wallet argRemoteFeatureFlagController(and error reporting) into STX messenger; extend Subscription Service messenger/actions to read remote flags; add tests and E2E mocks for remote flags@metamask/smart-transactions-controllerto ^22.0.0 and adjust initialization; update LavaMoat policies and yarn.lock for new depsWritten by Cursor Bugbot for commit d67bdba. This will update automatically on new commits. Configure here.