chore: remove browserify build in benchmark system (e2e & announcement)#41477
chore: remove browserify build in benchmark system (e2e & announcement)#41477DDDDDanica merged 35 commits intomainfrom
Conversation
…system Made-with: Cursor
…age-load-benchmark
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…DappPageLoadMetric import
…nchmark' into feat/integrate-dapp-page-load-benchmark
…onstants in shared/constants/benchmarks, add sample to section title
…age-load-benchmark
…age-load-benchmark
…ove-webpack-benchmark Integrate Playwright dapp page-load benchmark under flows/dapp-page-load, PR announcement section, and shared BENCHMARK_ANNOUNCE_SECTIONS. Keep webpack-only CI and artifact names (benchmark-chrome-webpack-pageLoadBenchmark.json). Made-with: Cursor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (8 files, +297 -272)
👨🔧 @HowardBraham (8 files, +297 -272)
👨🔧 @itsyoboieltr (8 files, +297 -272)
|
Builds ready [5e4424c]
Performance benchmarks: data not available. Bundle size diffs
|
Builds ready [a277f26]
⚡ Performance Benchmarks (Total: 🟢 2 pass · 🟡 2 warn · 🔴 0 fail)
Bundle size diffs
|
Builds ready [dad3120]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|
| interactionStats: { | ||
| url: `${hostUrl}/benchmarks/benchmark-${BENCHMARK_PLATFORMS.CHROME}-${BENCHMARK_BUILD_TYPES.WEBPACK}-interactionUserActions.json`, | ||
| // PR artifacts use the browserify interaction benchmark; literal matches CI output (see run-benchmark / upload). | ||
| url: `${hostUrl}/benchmarks/benchmark-${BENCHMARK_PLATFORMS.CHROME}-browserify-interactionUserActions.json`, |
| GITHUB_REF_NAME: ${{ github.head_ref || github.ref_name }} | ||
| BENCHMARK_GATED: ${{ !matrix.mainOnly || (github.event_name == 'push' && (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/release/'))) }} | ||
| # Run core benchmark steps (checkout, run, GH artifact) for every matrix job. | ||
| BENCHMARK_GATED: 'true' |
There was a problem hiding this comment.
this true is meaningless?
| `${HOST}/bundle-size/bundle_size.json`, | ||
| ); | ||
| expect(links.interactionStats.url).toBe( | ||
| `${HOST}/benchmarks/benchmark-chrome-browserify-interactionUserActions.json`, |
| }); | ||
|
|
||
| expect(result).toContain(`metamask-chrome-${VERSION}.zip`); | ||
| expect(result).toContain('build-dist-browserify'); |
|
|
||
| - **PRs:** User journey benchmarks run on **Chrome + Browserify** only. | ||
| - **Push to main/release:** User journey benchmarks also run on **Chrome + Webpack** (extra `benchmarks` matrix rows with `mainOnly: true` in `run-benchmarks.yml`) so we can compare build systems before releasing webpack to production. | ||
| - User journey presets run on **Chrome and Firefox** with the **Browserify** test build (`build-test` / `build-test-mv2` in CI), same as startup and interaction benchmarks. |
d08ac18 to
e889122
Compare
Builds ready [d08ac18]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9a4e08d. Configure here.
Builds ready [9a4e08d]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|
Builds ready [4ac0527] [reused from 9a4e08d]
⚡ Performance Benchmarks (Total: 🟢 0 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs
|
|




Description
Browserify is being removed from the build soon, so browserify-based builds and related code will go away. This PR removes the browserify-specific build for branchmark tests that are no longer needed.
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
CI benchmark generation, storage, and PR-announcement logic is re-keyed from
browserifytowebpack, which could break artifact naming/baseline lookups and regressions reporting if any downstream expectations remain.Overview
Removes
browserifyfrom the benchmark pipeline and standardizes benchmark artifacts, storage, and reporting around thewebpacktest build.GitHub Actions now runs benchmarks only for
chrome/firefoxonwebpack, dropsbuild-test-*-browserifydependencies, renames the dapp page-load artifact tobenchmark-chrome-webpack-pageLoadBenchmark.json, and gates Sentry/S3 upload (and AWS CLI install) to main/release runs.The MetaMask bot announcement/quality-gate code and tests are updated to consume
*-webpack-*artifact names by default, remove run-conditional user-journey build-type selection, and improve historical baseline resolution (including Firefox user-journey key disambiguation) so comparisons still map correctly after the artifact format change.Reviewed by Cursor Bugbot for commit f2422c8. Bugbot is set up for automated code reviews on this repo. Configure here.