chore(predict): opt in useNavigation to AppNavigationProp (Phase 4) (#33458)

<!--
Please submit this PR as a draft initially.

Do not mark it as "Ready for review" until this PR meets the canonical
Definition of Ready For Review in `docs/readme/ready-for-review.md`.

In short: the template must be materially complete (not just section
titles
present), all status checks must be currently passing, and the only
expected
follow-up commits must be reviewer-driven.
-->
<!--
mms-check directive vocabulary — read by
.github/scripts/shared/pr-template-checks.ts
at module load to build the validation plan. Directives are invisible in
rendered
markdown and must NOT be removed or edited without updating the
validator registry.

  type=text           Section must contain non-placeholder prose.
  type=changelog      Section must have a valid CHANGELOG entry: line.
type=issue-link Section must have a Fixes:/Closes:/Refs: line with a
value.
type=manual-testing Section must have real testing steps or an explicit
N/A.
type=screenshot Section must have evidence (image/URL) or an explicit
N/A.
type=checklist Section must have all checkboxes consciously checked.
required=true|false Whether a missing/invalid section runs the validator
at all.
blocking=true|false Whether a failure of this check fails the CI
workflow.
Default: false — failures are shown as warnings in the sticky
                      comment but do not block the PR.

Sections without a directive are checked for structural presence only.
-->

## **Description**

<!-- mms-check: type=text required=true -->

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
**Phase 4 of the incremental React Navigation typing migration — Predict
feature.**

Predict production call sites still used untyped `useNavigation()` (or
the feature-local `NavigationProp<PredictNavigationParamList>` /
`NativeStackNavigationProp<PredictNavigationParamList>`), so they were
checked only against the Predict param list (or the loose global
`ReactNavigation.RootParamList`) and could not enforce route names /
params against the app-wide `RootStackParamList`. This PR opts Predict
into the strict path via `useNavigation<AppNavigationProp>()` (and
`AppStackNavigationProp` where stack-only APIs are needed).

This is effectively **types-only**

### What changed

1. **Opt-in across Predict (~51 production files)**
- `useNavigation()` /
`useNavigation<NavigationProp<PredictNavigationParamList>>()` →
`useNavigation<AppNavigationProp>()`
- Added `import type { AppNavigationProp }` from
`app/core/NavigationService/types`
- Covers feed / home sections, market cards, market details, positions,
transactions, buy/sell previews, buy-with-any-token, add-funds,
world-cup modules, GTM modal, and hooks

2. **Guard prop retype**
(`app/components/UI/Predict/hooks/usePredictActionGuard.ts`)
- `navigation: NavigationProp<PredictNavigationParamList>` →
`navigation: AppNavigationProp`, so callers passing the root-typed
navigation no longer clash with the guard

3. **Stack-only APIs use `AppStackNavigationProp`**
(`app/components/UI/Predict/views/PredictBuyWithAnyToken/hooks/usePredictBuyActions.ts`)
-
`useNavigation<NativeStackNavigationProp<PredictNavigationParamList>>()`
→ `useNavigation<AppStackNavigationProp>()` (needs native-stack
`transitionEnd` event + `StackActions.pop()`)
   - Dropped the now-unused `NativeStackNavigationProp` import

4. **Removed a redundant cast**
(`app/components/UI/Predict/views/PredictMarketDetails/PredictMarketDetails.tsx`)
- The Polymarket-resolution Webview navigation previously did
`(navigation as unknown as AppNavigationProp).navigate(...)` because
`navigation` was typed to the Predict stack. Now that `navigation` is
`AppNavigationProp`, the cast (and its TODO) are gone

5. **`PredictEntryPoint` widened**
(`app/components/UI/Predict/types/navigation.ts`)
- Added `REWARDS`, `GTM_MODAL`, `BUY_PREVIEW` entry points that were
already used at runtime but not part of the type union

6. **`AppStackNavigationProp` JSDoc clarified**
(`app/core/NavigationService/types.ts`)
- Documents that it is for stack-only APIs (incl. native-stack events
like `transitionEnd`) and remains keyed to the loose global
`RootParamList` during Phase 4; prefer `AppNavigationProp` for strict
route/param checking


## **Changelog**

<!-- mms-check: type=changelog required=true blocking=true -->

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:null

## **Related issues**

<!-- mms-check: type=issue-link required=true -->

Fixes:https://consensyssoftware.atlassian.net/browse/MCWP-675

## **Manual testing steps**

<!-- mms-check: type=manual-testing required=true -->

N/A

## **Screenshots/Recordings**

<!-- mms-check: type=screenshot required=true -->

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

N/A

## **Pre-merge author checklist**

<!-- mms-check: type=checklist required=true -->

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Types-only refactor across Predict navigation; no logic changes beyond
removing an unsafe cast that should now type-check correctly.
> 
> **Overview**
> **Phase 4** of the React Navigation typing migration: Predict
production code now uses app-wide navigation types instead of untyped
`useNavigation()` or `NavigationProp<PredictNavigationParamList>`.
> 
> Across **~50+ Predict files** (components, views, hooks, contexts),
call sites switch to `useNavigation<AppNavigationProp>()` with imports
from `core/NavigationService/types`. **`usePredictActionGuard`** now
expects `AppNavigationProp`, so guarded flows align with root stack
typing. **`usePredictBuyActions`** uses `AppStackNavigationProp` for
stack-only APIs (e.g. `transitionEnd`, `StackActions`).
> 
> In **`PredictMarketDetails`**, Polymarket resolution Webview
navigation drops the `(navigation as unknown as AppNavigationProp)` cast
now that navigation is already root-typed.
> 
> **`PredictEntryPoint`** adds `REWARDS`, `GTM_MODAL`, and `BUY_PREVIEW`
to match runtime analytics usage. **`AppStackNavigationProp`** JSDoc
notes when to prefer it vs `AppNavigationProp` during Phase 4.
> 
> No intended runtime behavior change—compile-time route/param checking
against `RootStackParamList`.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
1c81771. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: weitingsun

app/components/UI/Predict/components/FeaturedCarousel/FeaturedCarouselCard.tsx

@@ -1,7 +1,8 @@
 import React, { useCallback } from 'react';
 import { TouchableOpacity } from 'react-native';
 import { Image } from 'expo-image';
-import { NavigationProp, useNavigation } from '@react-navigation/native';
+import { useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import { useTailwind } from '@metamask/design-system-twrnc-preset';
 import {
   Box,
@@ -21,10 +22,7 @@ import {
   PredictOutcome,
   PredictOutcomeToken,
 } from '../../types';
-import {
-  PredictNavigationParamList,
-  PredictEntryPoint,
-} from '../../types/navigation';
+import { PredictEntryPoint } from '../../types/navigation';
 import { formatPercentage } from '../../utils/format';
 import { PredictEventValues } from '../../constants/eventNames';
 import { usePredictActionGuard } from '../../hooks/usePredictActionGuard';
@@ -47,8 +45,7 @@ const FeaturedCarouselCard: React.FC<FeaturedCarouselCardProps> = ({
   entryPoint = PredictEventValues.ENTRY_POINT.PREDICT_FEED,
 }) => {
   const tw = useTailwind();
-  const navigation =
-    useNavigation<NavigationProp<PredictNavigationParamList>>();
+  const navigation = useNavigation<AppNavigationProp>();
   const { openBuySheet } = usePredictPreviewSheet();
   const { executeGuardedAction } = usePredictActionGuard({ navigation });
 

app/components/UI/Predict/components/FeaturedCarousel/FeaturedCarouselSportCard.tsx

@@ -1,6 +1,7 @@
 import React, { useCallback, useMemo } from 'react';
 import { TouchableOpacity } from 'react-native';
-import { NavigationProp, useNavigation } from '@react-navigation/native';
+import { useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import { useSelector } from 'react-redux';
 import { useTailwind } from '@metamask/design-system-twrnc-preset';
 import {
@@ -25,10 +26,7 @@ import {
   PredictOutcomeToken,
   PredictSportTeam,
 } from '../../types';
-import {
-  PredictNavigationParamList,
-  PredictEntryPoint,
-} from '../../types/navigation';
+import { PredictEntryPoint } from '../../types/navigation';
 import { formatPercentage } from '../../utils/format';
 import { PredictEventValues } from '../../constants/eventNames';
 import { usePredictActionGuard } from '../../hooks/usePredictActionGuard';
@@ -66,8 +64,7 @@ const FeaturedCarouselSportCard: React.FC<FeaturedCarouselSportCardProps> = ({
   entryPoint = PredictEventValues.ENTRY_POINT.PREDICT_FEED,
 }) => {
   const tw = useTailwind();
-  const navigation =
-    useNavigation<NavigationProp<PredictNavigationParamList>>();
+  const navigation = useNavigation<AppNavigationProp>();
   const { openBuySheet } = usePredictPreviewSheet();
   const { executeGuardedAction } = usePredictActionGuard({ navigation });
   const livePricesEnabled = useSelector(

app/components/UI/Predict/components/PredictActivity/PredictActivity.tsx

@@ -13,6 +13,7 @@ import { formatPercentage, formatPrice } from '../../utils/format';
 import { strings } from '../../../../../../locales/i18n';
 import Routes from '../../../../../constants/navigation/Routes';
 import { useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import { PredictActivityItem, PredictActivityType } from '../../types';
 import { useAnalytics } from '../../../../hooks/useAnalytics/useAnalytics';
 import { MonetizedPrimitive } from '../../../../../core/Analytics/MetaMetrics.types';
@@ -38,7 +39,7 @@ const PredictActivity: React.FC<PredictActivityProps> = ({
   containerStyle,
 }) => {
   const tw = useTailwind();
-  const navigation = useNavigation();
+  const navigation = useNavigation<AppNavigationProp>();
   const { trackEvent, createEventBuilder } = useAnalytics();
   const isDebit = item.type === PredictActivityType.BUY;
   const signedAmount = `${isDebit ? '-' : '+'}${formatPrice(

app/components/UI/Predict/components/PredictActivityDetail/PredictActivityDetail.tsx

@@ -1,4 +1,5 @@
 import { RouteProp, useNavigation, useRoute } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import React, { useMemo, useEffect } from 'react';
 import { SafeAreaView } from 'react-native-safe-area-context';
 import { useSelector } from 'react-redux';
@@ -35,7 +36,7 @@ import { PredictActivityDetailsSelectorsIDs } from '../../Predict.testIds';
 interface PredictActivityDetailProps {}
 
 const PredictActivityDetails: React.FC<PredictActivityDetailProps> = () => {
-  const navigation = useNavigation();
+  const navigation = useNavigation<AppNavigationProp>();
   const route =
     useRoute<RouteProp<PredictNavigationParamList, 'PredictActivityDetail'>>();
   const { activity } = route.params || {};

app/components/UI/Predict/components/PredictAddFundsSheet/PredictAddFundsSheet.tsx

@@ -16,8 +16,8 @@ import BottomSheetHeader from '../../../../../component-library/components/Botto
 import { ButtonVariants } from '../../../../../component-library/components/Buttons/Button/Button.types';
 import { usePredictDeposit } from '../../hooks/usePredictDeposit';
 import { usePredictActionGuard } from '../../hooks/usePredictActionGuard';
-import { NavigationProp, useNavigation } from '@react-navigation/native';
-import { PredictNavigationParamList } from '../../types/navigation';
+import { useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import { PredictEventValues } from '../../constants/eventNames';
 import {
   usePredictBottomSheet,
@@ -35,8 +35,7 @@ const PredictAddFundsSheet = forwardRef<
   PredictAddFundsSheetProps
 >(({ onDismiss }, ref) => {
   const tw = useTailwind();
-  const navigation =
-    useNavigation<NavigationProp<PredictNavigationParamList>>();
+  const navigation = useNavigation<AppNavigationProp>();
   const { deposit } = usePredictDeposit();
   const { executeGuardedAction } = usePredictActionGuard({
     navigation,

app/components/UI/Predict/components/PredictBalance/PredictBalance.tsx

@@ -10,7 +10,8 @@ import {
 import { useTailwind } from '@metamask/design-system-twrnc-preset';
 import images from 'images/image-icons';
 import React, { useCallback, useEffect, useMemo } from 'react';
-import { NavigationProp, useNavigation } from '@react-navigation/native';
+import { useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import { useQueryClient } from '@tanstack/react-query';
 import { useSelector } from 'react-redux';
 import { predictQueries } from '../../queries';
@@ -43,7 +44,6 @@ import { usePredictBalance } from '../../hooks/usePredictBalance';
 import { usePredictDeposit } from '../../hooks/usePredictDeposit';
 import { formatPrice } from '../../utils/format';
 import { usePredictActionGuard } from '../../hooks/usePredictActionGuard';
-import { PredictNavigationParamList } from '../../types/navigation';
 import { usePredictWithdraw } from '../../hooks/usePredictWithdraw';
 import { usePredictAccountState } from '../../hooks/usePredictAccountState';
 import { PredictEventValues } from '../../constants/eventNames';
@@ -71,8 +71,7 @@ const PredictBalance: React.FC<PredictBalanceProps> = ({
     selectPredictPortfolioEnabledFlag,
   );
 
-  const navigation =
-    useNavigation<NavigationProp<PredictNavigationParamList>>();
+  const navigation = useNavigation<AppNavigationProp>();
 
   const queryClient = useQueryClient();
   const {

app/components/UI/Predict/components/PredictCryptoUpDownMarketCard/PredictCryptoUpDownMarketCard.tsx

@@ -35,7 +35,8 @@ import {
   TextVariant,
 } from '@metamask/design-system-react-native';
 import { useTailwind } from '@metamask/design-system-twrnc-preset';
-import { NavigationProp, useNavigation } from '@react-navigation/native';
+import { useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import { useTheme } from '../../../../../util/theme';
 import { PredictEventValues } from '../../constants/eventNames';
 import { usePredictActionGuard } from '../../hooks/usePredictActionGuard';
@@ -54,10 +55,7 @@ import {
   type PredictMarketBuyButtonPress,
   type PriceQuery,
 } from '../../types';
-import type {
-  PredictEntryPoint,
-  PredictNavigationParamList,
-} from '../../types/navigation';
+import type { PredictEntryPoint } from '../../types/navigation';
 import {
   getEventStartTime,
   getCryptoSymbol,
@@ -1124,8 +1122,7 @@ const PredictCryptoUpDownMarketCard: React.FC<
   const isCompact = isCarousel;
   const tw = useTailwind();
   const { colors } = useTheme();
-  const navigation =
-    useNavigation<NavigationProp<PredictNavigationParamList>>();
+  const navigation = useNavigation<AppNavigationProp>();
   const { navigateToMarketDetails } = usePredictNavigation();
   const { openBuySheet } = usePredictPreviewSheet();
   const resolvedEntryPoint = useResolvedPredictEntryPoint(propEntryPoint);

app/components/UI/Predict/components/PredictCryptoUpDownPositions/PredictCryptoUpDownPosition.tsx

@@ -10,11 +10,8 @@ import {
   TextVariant,
 } from '@metamask/design-system-react-native';
 import { useTailwind } from '@metamask/design-system-twrnc-preset';
-import {
-  NavigationProp,
-  useIsFocused,
-  useNavigation,
-} from '@react-navigation/native';
+import { useIsFocused, useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import { useSelector } from 'react-redux';
 import { strings } from '../../../../../../locales/i18n';
 import Button, {
@@ -45,7 +42,6 @@ import {
   type PredictMarket,
   type PredictPosition,
 } from '../../types';
-import { PredictNavigationParamList } from '../../types/navigation';
 import { formatCents, formatPrice } from '../../utils/format';
 
 const AUTO_REFRESH_TIMEOUT = 5000;
@@ -62,8 +58,7 @@ const PredictCryptoUpDownPosition: React.FC<
   const tw = useTailwind();
   const privacyMode = useSelector(selectPrivacyMode);
   const isFocused = useIsFocused();
-  const navigation =
-    useNavigation<NavigationProp<PredictNavigationParamList>>();
+  const navigation = useNavigation<AppNavigationProp>();
 
   const { onCashOut } = usePredictCashOut({
     market,

app/components/UI/Predict/components/PredictDetailsHeaderSkeleton/PredictDetailsHeaderSkeleton.tsx

@@ -8,6 +8,7 @@ import {
 import { useTailwind } from '@metamask/design-system-twrnc-preset';
 import { Pressable } from 'react-native';
 import { useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import { useSafeAreaInsets } from 'react-native-safe-area-context';
 import Icon, {
   IconName,
@@ -27,7 +28,7 @@ const PredictDetailsHeaderSkeleton: React.FC<
   PredictDetailsHeaderSkeletonProps
 > = ({ testID = PREDICT_DETAILS_HEADER_SKELETON }) => {
   const tw = useTailwind();
-  const navigation = useNavigation();
+  const navigation = useNavigation<AppNavigationProp>();
   const insets = useSafeAreaInsets();
 
   return (

app/components/UI/Predict/components/PredictGTMModal/PredictGTMModal.tsx

@@ -1,4 +1,5 @@
 import { useNavigation } from '@react-navigation/native';
+import type { AppNavigationProp } from '../../../../../core/NavigationService/types';
 import React, { useState, useEffect } from 'react';
 import { Image, View } from 'react-native';
 import Animated, {
@@ -37,7 +38,7 @@ import { PREDICT_GTM_MODAL_TEST_IDS } from './PredictGTMModal.testIds';
 
 const PredictGTMModal = () => {
   const { trackEvent, createEventBuilder } = useAnalytics();
-  const { navigate } = useNavigation();
+  const { navigate } = useNavigation<AppNavigationProp>();
   const theme = useTheme();
   const [imageLoaded, setImageLoaded] = useState(false);
   const opacity = useSharedValue(0);