Skip to content

test(MMQA-1667): verify performance-only PR reuses main BrowserStack builds#33270

Draft
javiergarciavera wants to merge 3 commits into
mainfrom
cursor/verify-perf-only-skip-build-4b2e
Draft

test(MMQA-1667): verify performance-only PR reuses main BrowserStack builds#33270
javiergarciavera wants to merge 3 commits into
mainfrom
cursor/verify-perf-only-skip-build-4b2e

Conversation

@javiergarciavera

Copy link
Copy Markdown
Contributor

Purpose

Third MMQA-1667 verification path, distinct from:

  • #33267 — smoke Detox test-only (reuse main APK/app, no compile/repack)
  • #33268app JS change (normal reuse+repack / native build)

This PR only touches tests/performance/**, so it should:

  1. Set native_build_needed=false (same test-only gate for Detox builds if smoke also selected)
  2. Drive performance E2E with reuse_main_builds=true
  3. Prefer resolve-main-browserstack-apps (apps with custom_id prefix MetaMask-Android-*-main-*) instead of building + uploading fresh dual APKs to BrowserStack

Change

  • One comment in tests/performance/onboarding/import-wallet.spec.ts

How to verify in CI

  1. Remove pr-not-ready-for-e2e if present; ensure performance selection/labels allow the suite to run if needed.
  2. In performance workflow: look for Resolve main-branch BrowserStack Android apps (should run) and dual Android BrowserStack build/upload skipped or not needed.
  3. Confirm no Test-only gate failure if main BrowserStack apps with the new main- custom_id are not uploaded yet — that is an expected transition note after ci(MMQA-1667): skip native builds when PR only changes E2E/performance tests #33180.

Do not merge — close after verification.

Open in Web Open in Cursor 

…builds

Only changes a performance E2E spec so CI takes test-only path for
native builds and resolve-main-browserstack-apps for performance E2E.

Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jul 14, 2026
@metamask-ci metamask-ci Bot added team-qa QA team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jul 14, 2026
@metamask-ci

metamask-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@javiergarciavera javiergarciavera removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jul 14, 2026
cursoragent and others added 2 commits July 14, 2026 16:45
Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
Comment-only delta was ignored (no performance/smoke tags). Adjust
timer and token-load timeouts to exercise main BrowserStack reuse.

Co-authored-by: javiergarciavera <javiergarciavera@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: @PerformanceOnboarding
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
Only one file changed: tests/performance/onboarding/import-wallet.spec.ts. No app source code was modified. The changes are:

  1. A comment added (cosmetic)
  2. Minor timer threshold bumps: ios 1500→1520ms, android 1800→1820ms for timer1, and walletTokenLoadTimeoutMs 60_000→60_500ms

The PR comment explicitly states these threshold bumps are intentional to make the PR a "real perf-spec delta (not comment-only)" per MMQA-1667. Since no app code changed and no smoke spec files were modified, no E2E smoke tags are needed.

Performance Test Selection:
The changed file tests/performance/onboarding/import-wallet.spec.ts explicitly declares and uses the PerformanceOnboarding tag (imported from tags.performance.js). The spec tests the SRP import onboarding flow with 50+ accounts. The changes include actual (non-cosmetic) threshold modifications to TimerHelper instances that measure onboarding performance milestones. Since the spec file itself changed with functional threshold adjustments, the @PerformanceOnboarding performance test should run to validate the updated thresholds are correct and the onboarding flow still meets the new performance criteria.

View GitHub Actions results

@github-actions

Copy link
Copy Markdown
Contributor

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

⚠️ Results incomplete — No test results found


Branch: cursor/verify-perf-only-skip-build-4b2e · Build: Normal · Commit: 5dbf7e6 · View full run

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants