Skip to content

fix(confirmations): align Edit network fee sheet with elevated surfaces#33294

Open
georgewrmarshall wants to merge 2 commits into
mainfrom
fix/tmcu-1016-edit-network-fee-pure-black
Open

fix(confirmations): align Edit network fee sheet with elevated surfaces#33294
georgewrmarshall wants to merge 2 commits into
mainfrom
fix/tmcu-1016-edit-network-fee-pure-black

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Description

In Pure Black dark mode, the Edit network fee bottom sheet (EstimatesModal) showed two visual regressions:

  1. The sheet container used background.default (#000000), so it did not match other elevated confirmation bottom sheets.
  2. The selected gas option row (e.g. Market) painted a primary.muted fill, creating a visible dark blue/grey band inside the sheet.

This PR applies the same style-only stopgap used elsewhere in confirmations (#33152, gas-fee-token-modal):

  • estimates-modal.styles.tsgetElevatedSurfaceColor() + muted border in pure black dark mode
  • gas-option.styles.ts — omit primary.muted row fill in pure black dark mode; selection remains on the left-edge indicator

Changelog

CHANGELOG entry: Fixed Edit network fee bottom sheet styling in Pure Black theme so the sheet surface and selected gas option match other elevated confirmation sheets.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-1016

Refs: https://consensyssoftware.atlassian.net/browse/TMCU-622

Manual testing steps

Feature: Edit network fee sheet in Pure Black theme

  Scenario: Selected gas option and sheet surface match elevated sheets
    Given dark mode is enabled and MM_PURE_BLACK_PREVIEW=true
    And the user starts a send flow on an EVM network (e.g. Base)
    When the user opens the confirmation screen and taps Edit network fee
    Then the bottom sheet surface matches other elevated confirmation sheets
    And the selected gas option shows only the left-edge indicator (no primary.muted row fill)
    And unselected options remain visually consistent with the sheet background

Unit tests: gas-option.styles.test.ts, estimates-modal.styles.test.ts, and existing component tests pass.

Screenshots/Recordings

Before

Screenshot 2026-07-14 at 2 44 19 PM

After

Screenshot 2026-07-14 at 2 44 16 PM

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

Remove the primary.muted fill on selected gas options in pure black dark
mode and use getElevatedSurfaceColor for the EstimatesModal container so
the sheet matches other confirmation bottom sheets.

Fixes TMCU-1016

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Mobile label Jul 14, 2026
@metamask-ci

metamask-ci Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Pre-merge author checklist has unchecked items (e.g. "I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@georgewrmarshall georgewrmarshall changed the title fix(pure-black): align Edit network fee sheet with elevated surfaces fix(confirmations): align Edit network fee sheet with elevated surfaces Jul 14, 2026
@georgewrmarshall georgewrmarshall self-assigned this Jul 14, 2026
Leave primary.muted selection fill as-is; pure black fix is limited to
EstimatesModal elevated surface styling.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added size-S and removed size-M labels Jul 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR contains only two files:

  1. estimates-modal.styles.ts - A purely cosmetic styling change to the estimates modal container. It updates the background color to use getElevatedSurfaceColor() (instead of direct theme.colors.background.default) and adds a conditional 1px muted border for pure black dark mode. This is a visual-only change with no impact on transaction logic, confirmation flows, or any functional behavior.
  2. estimates-modal.styles.test.ts - A new unit test file covering the styling changes above.

These changes are cosmetic in nature (background color and border styling only) and fall under the "COSMETIC CHANGES — IGNORE FOR TEST SELECTION" guidance. The changes do not affect any user-facing functional flows, state management, business logic, or E2E-testable behaviors. No E2E smoke tests are warranted.

Performance Test Selection:
The changes are purely cosmetic styling updates (background color and border) to the estimates modal stylesheet. There is no impact on rendering performance, data fetching, or any performance-sensitive flows. No performance tests are needed.

View GitHub Actions results

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 14, 2026 21:45
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 14, 2026 21:45
@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jul 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low AI analysis: low risk size-S team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant