fix: remove whole redux state pass through for bridge selectors

[infiniteflower]

Description

This PR removes whole Redux-state passthrough inputs from three Bridge account selectors. The selectors now compose granular token and account inputs, preventing result recomputation on unrelated dispatches while preserving selected account-group lookup, destination scope matching, and the existing Set<AccountId> API.

It also adds EVM and non-EVM value coverage plus recomputation and reference-stability tests.

Changelog

CHANGELOG entry: null

Related issues

Fixes: #31269

Manual testing steps

N/A — this is an internal selector memoization change with no UI behavior change.

Automated verification: run yarn jest app/selectors/bridge.test.ts and confirm all 24 tests pass, including the unrelated-state recomputation and stable Set-reference cases.

Screenshots/Recordings

Before

N/A — no UI changes.

After

N/A — no UI changes.

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Medium Risk
Destination account eligibility logic was rewritten (different data source and anyScopesMatch vs per-scope queries); behavior should match but account picking for bridge is user-facing if wrong.

Overview
Refactors three Bridge account selectors so they no longer depend on the entire RootState, which was forcing recomputation on every unrelated dispatch.

selectSourceWalletAddress and selectBatchSellSourceWalletAddress now compose selectSourceToken / selectBatchSellSourceTokens with selectSelectedInternalAccountByScope instead of calling scope lookup inside a (state) => state input. selectValidDestInternalAccountIds drops createDeepEqualSelector and selectInternalAccountsByScope in favor of selectInternalAccountsById plus anyScopesMatch for destination scope and EVM wildcard (eip155:0) filtering, while still returning a Set<AccountId>.

Tests add shared bridge selector mock state, EVM/Solana coverage, and assertions that unrelated bridge fields (e.g. sourceAmount) do not trigger recomputation or new Set references until the relevant token changes.

^{Reviewed by Cursor Bugbot for commit f604031. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamask-ci]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[github-actions]

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeSwap, SmokeConfirmations
• Selected Performance tags: None (no tests recommended)
• Risk Level: medium
• AI Confidence: 85%

click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are in app/selectors/bridge.ts which contains selectors used throughout the bridge/swap flow:

1. selectSourceWalletAddress: Refactored to use selectSelectedInternalAccountByScope as a direct input selector instead of passing the full state. This selector is used in useBridgeQuoteRequest, useIsHardwareWalletForBridge, useBridgeConfirm, useSubmitBridgeTx, and useQuickBuyController.

2. selectBatchSellSourceWalletAddress: Similar refactoring, used in useSubmitBatchSellTx and useBatchSellQuoteRequest.

3. selectValidDestInternalAccountIds: Changed from createDeepEqualSelector to createSelector, and replaced selectInternalAccountsByScope with anyScopesMatch utility. Used in useDestinationAccounts.

These selectors are critical for determining wallet addresses in bridge/swap flows. The refactoring changes how memoization works and how account scopes are matched. While the test file adds comprehensive unit tests validating the new behavior, E2E tests should verify the actual swap/bridge flows still work correctly end-to-end.

SmokeSwap is selected because the changed selectors directly power the bridge/swap quote request, confirmation, and submission flows.
SmokeConfirmations is selected per the SmokeSwap tag description: "When selecting SmokeSwap, also select SmokeConfirmations (transaction confirmations are part of the flow)."

The changes are a refactoring (not new functionality), with unit tests added, so risk is medium rather than high.

Performance Test Selection:
The changes are selector refactoring in bridge.ts - improving memoization and account scope matching logic. While these selectors are used in swap flows, the changes are about correctness of selector inputs/memoization rather than performance-sensitive rendering or loading operations. No performance test tags are warranted for this type of refactoring.

View GitHub Actions results

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud