Revert publish-release order

Author: Mrtenz

.github/workflows/create-release-pr.yml

@@ -4,15 +4,15 @@ on:
   workflow_dispatch:
     inputs:
       base-branch:
-        description: "The base branch for git operations and the pull request."
-        default: "main"
+        description: 'The base branch for git operations and the pull request.'
+        default: 'main'
         required: true
       release-type:
         description: 'A SemVer version diff, i.e. major, minor, or patch. Mutually exclusive with "release-version".'
         required: false
         type: choice
         options:
-          - ""
+          - ''
           - major
           - minor
           - patch

.github/workflows/publish-release.yml

@@ -10,8 +10,32 @@ on:
       PUBLISH_DOCS_TOKEN:
         required: true
 jobs:
+  publish-release:
+    permissions:
+      contents: write
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout and setup environment
+        uses: MetaMask/action-checkout-and-setup@v3
+        with:
+          is-high-risk-environment: true
+          ref: ${{ github.sha }}
+      - uses: MetaMask/action-publish-release@v3
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - run: yarn build
+      - name: Upload build artifacts
+        uses: actions/upload-artifact@v7
+        with:
+          name: publish-release-artifacts-${{ github.sha }}
+          retention-days: 4
+          include-hidden-files: true
+          path: |
+            ./dist
+            ./node_modules/.yarn-state.yml
+
   publish-npm-dry-run:
-    name: Publish to NPM (dry run)
+    needs: publish-release
     runs-on: ubuntu-latest
     steps:
       - name: Checkout and setup environment
@@ -33,7 +57,6 @@ jobs:
           SKIP_PREPACK: true
 
   publish-npm:
-    name: Publish to NPM
     needs: publish-npm-dry-run
     runs-on: ubuntu-latest
     environment: npm-publish
@@ -57,7 +80,6 @@ jobs:
           SKIP_PREPACK: true
 
   get-release-version:
-    name: Get release version
     needs: publish-npm
     runs-on: ubuntu-latest
     outputs:
@@ -91,29 +113,3 @@ jobs:
       destination_dir: latest
     secrets:
       PUBLISH_DOCS_TOKEN: ${{ secrets.PUBLISH_DOCS_TOKEN }}
-
-  publish-release:
-    name: Publish release to GitHub
-    needs: publish-npm
-    permissions:
-      contents: write
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout and setup environment
-        uses: MetaMask/action-checkout-and-setup@v3
-        with:
-          is-high-risk-environment: true
-          ref: ${{ github.sha }}
-      - uses: MetaMask/action-publish-release@v3
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - run: yarn build
-      - name: Upload build artifacts
-        uses: actions/upload-artifact@v7
-        with:
-          name: publish-release-artifacts-${{ github.sha }}
-          retention-days: 4
-          include-hidden-files: true
-          path: |
-            ./dist
-            ./node_modules/.yarn-state.yml