fix: multichain core - stores adapters and client implementation#1314
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1314 +/- ##
=======================================
Coverage 74.93% 74.93%
=======================================
Files 184 184
Lines 4513 4513
Branches 1105 1105
=======================================
Hits 3382 3382
Misses 1131 1131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elribonazo
force-pushed
the
features/multichain-stores
branch
2 times, most recently
from
July 11, 2025 06:24
4122f73 to
6d69f40
Compare
elribonazo
force-pushed
the
features/multichain-stores
branch
from
July 14, 2025 10:50
ca8d15e to
e72cedf
Compare
elribonazo
marked this pull request as ready for review
July 14, 2025 10:57
elribonazo
enabled auto-merge (squash)
July 14, 2025 11:07
chakra-guy
approved these changes
Jul 14, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
Storage adapters are used by the SDK and dApps to store specific values in the native storage, example, the anonId needed for Analytics.
This PR integrates the Storage wrapper, a simple class that will be used across the SDK to abstract from the storage and provide a simple to use interface with, setAnonId, removeAnonId and other utility functions for other attributes.
We also integrate 3 different storages, RN, Browser and Node.
RN is using internally @react-native-async-storage/async-storage
Browser is using internally localstorage
Node is using internally FS
Added basic unitary test coverage
Checklist