Skip to content

fix: fix E2E fixtures for onboarded state#1316

Merged
christopherferreira9 merged 2 commits into
mainfrom
christopher/fix-imports-mobile-fixture
Jul 17, 2025
Merged

fix: fix E2E fixtures for onboarded state#1316
christopherferreira9 merged 2 commits into
mainfrom
christopher/fix-imports-mobile-fixture

Conversation

@christopherferreira9

@christopherferreira9 christopherferreira9 commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

Explanation

This PR improves the e2e structure by:

  • remove unnecessary static classes and fixes
  • fixes the onboarded state fixture
  • fixes imports being wrongly used where the class would be imported instead of the exported instance of each class
  • cleans non used code
  • following the mobile code structure for E2E

Base E2E passing on Browserstack:

video-363d19f9fe9be2535463e898029a6ddc6c8e6979.mp4

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner July 15, 2025 16:52
@cursor

cursor Bot commented Jul 15, 2025

Copy link
Copy Markdown

🚨 BugBot couldn't run

Something went wrong. Try again by commenting "bugbot run", or contact support (requestId: serverGenReqId_90b11d66-cc57-4ac3-bd39-4e9dbfd68d1d).

@christopherferreira9

Copy link
Copy Markdown
Contributor Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


Was this report helpful? Give feedback by reacting with 👍 or 👎

@codecov

codecov Bot commented Jul 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.93%. Comparing base (449a82a) to head (7d4ce3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1316   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files         184      184           
  Lines        4513     4513           
  Branches     1105     1105           
=======================================
  Hits         3382     3382           
  Misses       1131     1131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@christopherferreira9 christopherferreira9 merged commit 30f9d30 into main Jul 17, 2025
40 checks passed
@christopherferreira9 christopherferreira9 deleted the christopher/fix-imports-mobile-fixture branch July 17, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants