fix: improve multichain SDK to use ConnectionRequests as QRCodes

[elribonazo]

Explanation

Multichain SDK was previous using sessionRequests to generate QRCodes, during a while this was enough for us to start testing the Dapps (node, react).

Now the Mobile app can already establish connections with the Mobile wallet protocol relay server, and we need to integrate this ConnectionRequests into the multichain SDK so the QRCodes are created properly.

Difference is really not much (types extracted from MWP)

type ConnectionMode = "trusted" | "untrusted";
type SessionRequest = {
    id: string;
    mode: ConnectionMode;
    channel: string;
    publicKeyB64: string;
    expiresAt: number;
};
type DappSettings = { name?: string; url?: string } & ({ iconUrl?: string } | { base64Icon?: string });
type ConnectionRequest = {
	sessionRequest: SessionRequest;
	metadata: { dapp: DappSettings; sdk: { version: string; platform: string }};
};

This will make the QRCodes on install modal (all platforms) to use the right payload to generate QRCodes.

References

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.93%. Comparing base (22b64c7) to head (c3b0f1e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files         184      184           
  Lines        4513     4513           
  Branches     1105     1105           
=======================================
  Hits         3382     3382           
  Misses       1131     1131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ffmcgee725]

would typing these as string and number respectively cause us problems downstream, or would it be okay ?

[elribonazo]

done

[wenfix]

Does it make sense to use more descriptive names for the generic parameters here (R and T)? Something like SignInConfirmationMethod for the first one, don't have a great name for the second one. No is an okay answer.

[elribonazo]

I will add that

[elribonazo]

Options + Data type though but improved them

[wenfix]

Could we use an enum for event names like session_request?

[elribonazo]

on is currently not typed thats a good point, I think @chakra-guy is aware of this. It won't be with an enum though but it knows perfectly which events we have

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​multichain-api-client@​0.6.5 ⏵ 0.8.0	+3		+1	+5

View full report

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud