Skip to content

fix: install modal not closing#1356

Merged
elribonazo merged 1 commit into
mainfrom
fix/multichain-modal-web-close
Oct 2, 2025
Merged

fix: install modal not closing#1356
elribonazo merged 1 commit into
mainfrom
fix/multichain-modal-web-close

Conversation

@elribonazo

@elribonazo elribonazo commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Explanation

This issue only happens on web install modal.

Due to the recent improvements and separation of concerns applied to the multichain sdk the install modal was not unloading, despite we were capturing the error message "User closed modal" but the install modal was never going away.

Every single time we request the install modal to show we are creating a new session request and showing a QRCode. If we leave the window open with the QRCode for more than 60 seconds another automatic QRCode will display

Screen.Recording.2025-10-02.at.19.39.46.mov

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Note

Unmounts the active modal during unload() to ensure the install modal properly closes.

Written by Cursor Bugbot for commit 2f31b64. This will update automatically on new commits. Configure here.

@elribonazo elribonazo requested a review from a team as a code owner October 2, 2025 17:40
@elribonazo elribonazo requested a review from adonesky1 October 2, 2025 17:41
adonesky1
adonesky1 previously approved these changes Oct 2, 2025
@elribonazo elribonazo force-pushed the fix/multichain-modal-web-close branch from faf8a62 to 2f31b64 Compare October 2, 2025 18:13
@elribonazo elribonazo enabled auto-merge (squash) October 2, 2025 18:13
@elribonazo elribonazo requested a review from adonesky1 October 2, 2025 18:13
@elribonazo elribonazo merged commit ecba1b4 into main Oct 2, 2025
48 of 71 checks passed
@elribonazo elribonazo deleted the fix/multichain-modal-web-close branch October 2, 2025 18:32
@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2025

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants