fix: install modal not closing#1356
Merged
Merged
Conversation
adonesky1
previously approved these changes
Oct 2, 2025
faf8a62 to
2f31b64
Compare
adonesky1
approved these changes
Oct 2, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
This issue only happens on web install modal.
Due to the recent improvements and separation of concerns applied to the multichain sdk the install modal was not unloading, despite we were capturing the error message "User closed modal" but the install modal was never going away.
Every single time we request the install modal to show we are creating a new session request and showing a QRCode. If we leave the window open with the QRCode for more than 60 seconds another automatic QRCode will display
Screen.Recording.2025-10-02.at.19.39.46.mov
References
Checklist
Note
Unmounts the active modal during
unload()to ensure the install modal properly closes.Written by Cursor Bugbot for commit 2f31b64. This will update automatically on new commits. Configure here.