Skip to content

feat: add deeplink compression logic to sdk-multichain#1360

Merged
ffmcgee725 merged 3 commits into
mainfrom
jc/sdk-v2-deeplink-compression
Oct 8, 2025
Merged

feat: add deeplink compression logic to sdk-multichain#1360
ffmcgee725 merged 3 commits into
mainfrom
jc/sdk-v2-deeplink-compression

Conversation

@ffmcgee725

@ffmcgee725 ffmcgee725 commented Oct 8, 2025

Copy link
Copy Markdown
Member

Explanation

The goal of this PR is to add deeplink compression logic to decrease size of transported payloads across established connections.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Note

Compresses connection request payloads for deeplink and universal links via pako-based utility and updates deps.

  • Links generation (packages/sdk-multichain/src/ui/index.ts):
    • Compress ConnectionRequest JSON before encoding for createDeeplink and createUniversalLink.
    • Append c=1 flag to indicate compressed payloads.
  • Utils (packages/sdk-multichain/src/multichain/utils/index.ts):
    • Add cross-platform base64Encode and compressString (pako deflate) utilities; export compressString.
  • Dependencies (packages/sdk-multichain/package.json):
    • Add pako and @types/pako.

Written by Cursor Bugbot for commit 9f3894e. This will update automatically on new commits. Configure here.

@ffmcgee725
ffmcgee725 marked this pull request as ready for review October 8, 2025 09:49
@ffmcgee725
ffmcgee725 requested a review from a team as a code owner October 8, 2025 09:49
cursor[bot]

This comment was marked as outdated.

@codecov

codecov Bot commented Oct 8, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.99%. Comparing base (7af4f97) to head (9f3894e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files         184      184           
  Lines        4519     4519           
  Branches     1108     1108           
=======================================
  Hits         3389     3389           
  Misses       1130     1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2025

Copy link
Copy Markdown

@elribonazo elribonazo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome PR @ffmcgee725 thanks!

@ffmcgee725
ffmcgee725 merged commit 886f71e into main Oct 8, 2025
44 checks passed
@ffmcgee725
ffmcgee725 deleted the jc/sdk-v2-deeplink-compression branch October 8, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants