Skip to content

Fix/multichain react native#1366

Merged
chakra-guy merged 13 commits into
mainfrom
fix/multichain-react-native
Oct 14, 2025
Merged

Fix/multichain react native#1366
chakra-guy merged 13 commits into
mainfrom
fix/multichain-react-native

Conversation

@chakra-guy

@chakra-guy chakra-guy commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Note

Refactors deeplink handling into RPC client, adds MWP session caching and transport persistence tweaks, updates tests/error messaging, and introduces a new React Native playground app.

  • Multichain SDK/Core:
    • Move deeplink triggering for invokeMethod into RPCClient; construct client with full options and support mobile preferredOpenLink.
    • Persist transport type in storage (Browser/MPW) and refine secure/non-secure connect logic; improve deeplink connect flow and error cleanup.
    • Guard window event listeners and fix beforeunload behavior using modal isMounted.
  • MWP Transport:
    • Add cached wallet_getSession storage and reuse; write-through on session changes; skip revoke during upgrades; safer window focus reconnect.
  • UI:
    • createDeeplink/createUniversalLink accept optional request and return base URLs when absent; share compression logic.
  • Tests:
    • Update expectations for cached session behavior and new error message; remove revocation-on-upgrade test.
  • Playground:
    • Add playground/multichain-react-native (Expo RN) sample dapp.
  • Dependencies:
    • Bump @metamask/mobile-wallet-protocol-core to ^0.3.0; add Expo/RN deps for new playground.

Written by Cursor Bugbot for commit 73cb125. This will update automatically on new commits. Configure here.

@chakra-guy
chakra-guy requested a review from a team as a code owner October 13, 2025 07:56
cursor[bot]

This comment was marked as outdated.

@codecov

codecov Bot commented Oct 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.99%. Comparing base (7587a0e) to head (73cb125).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1366   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files         184      184           
  Lines        4519     4519           
  Branches     1108     1108           
=======================================
  Hits         3389     3389           
  Misses       1130     1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@chakra-guy
chakra-guy merged commit 74f90c1 into main Oct 14, 2025
44 checks passed
@chakra-guy
chakra-guy deleted the fix/multichain-react-native branch October 14, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants