Skip to content

playground: Fix sign message bug#1372

Merged
chakra-guy merged 1 commit into
mainfrom
ts/fix-playground-apps
Oct 15, 2025
Merged

playground: Fix sign message bug#1372
chakra-guy merged 1 commit into
mainfrom
ts/fix-playground-apps

Conversation

@chakra-guy

@chakra-guy chakra-guy commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator

Explanation

This PR fixes the bug in the playground apps around solana message signing

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

Note

Normalize invoke parameters by chain (keep objects for Solana methods, arrays for EVM) and update ScopeCards to use the new signature.

  • Helpers:
    • Update normalizeMethodParams(method, params, scope) in playground/multichain-react(-native)/src/helpers/MethodInvocationHelpers.ts to:
      • Keep params as objects for Solana methods/scopes.
      • Ensure arrays for EVM methods.
      • Retain special handling for eth_signTypedData_v3/v4.
  • Components:
    • Update ScopeCard.tsx (React and React Native) to pass scope to normalizeMethodParams and align logs.
    • Minor JSX/className formatting cleanup in React ScopeCard.
  • Solana:
    • Import ordering cleanup in solana-method-signatures.ts (React).

Written by Cursor Bugbot for commit db710fe. This will update automatically on new commits. Configure here.

@chakra-guy chakra-guy requested a review from a team as a code owner October 15, 2025 10:09
Comment thread playground/multichain-react/src/helpers/MethodInvocationHelpers.ts
@codecov

codecov Bot commented Oct 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.99%. Comparing base (07036cd) to head (db710fe).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1372   +/-   ##
=======================================
  Coverage   74.99%   74.99%           
=======================================
  Files         184      184           
  Lines        4519     4519           
  Branches     1108     1108           
=======================================
  Hits         3389     3389           
  Misses       1130     1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@chakra-guy chakra-guy merged commit 462a842 into main Oct 15, 2025
44 checks passed
@chakra-guy chakra-guy deleted the ts/fix-playground-apps branch October 15, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants