Skip to content

Commit ce9b92a

Browse files
sirtimidclaude
andauthored
fix(pr-skill): move changelog phase after PR creation (#934)
## Summary The changelog update phase needs the PR number to create proper links (e.g. `[#123]`) in entries. Previously, changelogs were updated in Phase 4 before the PR was created in Phase 5, making it impossible to include the PR link. - Swap Phase 4 (changelogs) and Phase 5 (PR creation) so the PR number is available when writing changelog entries - Add explicit emphasis on key `updating-changelogs.md` rules that were being missed: consumer-perspective thinking, combining like changes, splitting disparate changes, and linking the PR number ## Testing This is a docs-only change to a Claude Code skill definition. Verified the final file reads correctly with proper phase ordering and emphasis. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Docs-only change to the PR-creation skill workflow; minimal risk beyond process/labeling instructions potentially being followed incorrectly. > > **Overview** > Reorders the `pr` Claude skill workflow so the PR is created in Phase 4 before changelog updates, ensuring the PR number is available for changelog links. > > Adds explicit Phase 5 guidance to either apply a `no-changelog` label for non-consumer-facing changes or update changelogs with emphasized rules (consumer-focused wording, combining/splitting entries, and linking the PR) before presenting results. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d817845. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 2e05c52 commit ce9b92a

1 file changed

Lines changed: 22 additions & 8 deletions

File tree

.claude/skills/pr/SKILL.md

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,13 +107,7 @@ Otherwise, after all launched subagents complete:
107107
- Abort
108108
4. If there are no blockers, briefly summarize the findings and proceed.
109109

110-
## Phase 4: Update changelogs
111-
112-
**MANDATORY — DO NOT SKIP.** Each PR must update changelogs for all packages with consumer-facing changes.
113-
Read the instructions in [`docs/contributing/updating-changelogs.md`](../../../docs/contributing/updating-changelogs.md) and follow them to the letter.
114-
Commit the changes to the current branch with the commit message "docs: Update changelogs" before creating the PR.
115-
116-
## Phase 5: Create the PR
110+
## Phase 4: Create the PR
117111

118112
1. Run `gh pr create` to create a pull request. The PR body should include:
119113

@@ -123,4 +117,24 @@ Commit the changes to the current branch with the commit message "docs: Update c
123117

124118
**If this is a stacked PR**, add `--draft` to create it as a draft PR.
125119

126-
2. Return the PR URL and any relevant information. If a review was performed, include the review summary.
120+
2. Note the PR number from the created PR URL — it is needed for changelog entries. Proceed to Phase 5 before presenting results to the user.
121+
122+
## Phase 5: Update changelogs
123+
124+
**MANDATORY — DO NOT SKIP.** Analyze the diff and determine whether any changes are consumer-facing (i.e., affect the behavior or API of a published or private package).
125+
126+
- **If there are NO consumer-facing changes** (e.g., docs-only, CI, tooling, skill definitions, dev scripts): add the `no-changelog` label to the PR via `gh pr edit <number> --add-label no-changelog` and skip the rest of this phase.
127+
- **If there ARE consumer-facing changes**: update changelogs as described below.
128+
129+
Read the instructions in [`docs/contributing/updating-changelogs.md`](../../../docs/contributing/updating-changelogs.md) and follow them **to the letter**. In particular:
130+
131+
- **Think from the consumer's perspective.** A changelog is not a git history. For each affected package, ask: "What changed for someone who depends on this package?" Describe changes in natural language; do not simply reuse commit messages.
132+
- **Combine like changes.** If multiple commits contribute to a single logical change within one package, write one changelog entry — not one per commit.
133+
- **Split disparate changes.** If one commit touches unrelated concerns in a single package, write separate entries.
134+
- **Link the PR.** Use the PR number from Phase 4 in each entry (e.g. `([#123](https://github.com/.../pull/123))`).
135+
136+
Commit the changelog updates to the current branch with the message "docs: Update changelogs" and push.
137+
138+
## Done
139+
140+
Present the PR URL and any relevant information to the user. If a review was performed, include the review summary.

0 commit comments

Comments
 (0)