chore: align external dep ranges with core monorepo (#598)

* chore: align external dep ranges with core monorepo

Core's `yarn.config.cjs` enforces consistent version ranges for
every external dep across all monorepo packages
(`expectConsistentDependenciesAndDevDependencies`). This PR aligns
6 of 7 remaining drift points so the migrated package doesn't fail
constraints.

- @babel/runtime           ^7.24.1  -> ^7.23.9
- @lavamoat/allow-scripts  ^3.2.1   -> ^3.0.4
- @types/eslint            ^9.6.1   -> ^8.44.7
- @types/lodash            ^4.14.194-> ^4.14.191
- @types/node              ^18.19.17-> ^16.18.54
- typescript-eslint        ^8.39.0  -> ^8.48.0

`nock` is intentionally NOT aligned: downgrading from `^14.0.0-beta.7`
to core's `^13.3.1` makes 22 tests fail with HTTP 500s (the mock
interceptors aren't matching). Will need to add `nock` to
ALLOWED_INCONSISTENT_DEPENDENCIES in core during Phase B, or upgrade
core to v14 separately.

Lint, build, and 196/196 tests remain green.

* chore: drop @types/node — unused

Source has no direct Node API usage (no fs/path/crypto/process/Buffer
references; tsconfig lib is ["ES2020", "DOM"]). Transitive consumers
that need Node types (jest, etc.) install their own copy.

Build, lint, and 196/196 tests all pass without it.

* chore: drop @types/eslint, @types/jest, @types/lodash — unused

Source doesn't import any of these directly. jest 29 ships its
own types via @jest/globals; lodash/eslint types come in
transitively. tsconfig has `skipLibCheck: true` so missing
declaration files for these aren't checked anyway.

Build, lint, and 196/196 tests all pass without them.

* chore: bump @metamask/profile-sync-controller to ^28.2.0 (core caught up)

Author: cryptodev-2s

CHANGELOG.md

@@ -18,7 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Bump `bignumber.js` from `^9.0.1` to `^9.1.2` ([#597](https://github.com/MetaMask/smart-transactions-controller/pull/597))
 - Bump `fast-json-patch` from `^3.1.0` to `^3.1.1` ([#597](https://github.com/MetaMask/smart-transactions-controller/pull/597))
 - Bump `@metamask/controller-utils` from `^12.1.0` to `^12.2.0` ([#590](https://github.com/MetaMask/smart-transactions-controller/pull/590))
-- Bump `@metamask/profile-sync-controller` from `^28.1.0` to `^28.1.1` ([#590](https://github.com/MetaMask/smart-transactions-controller/pull/590))
+- Bump `@metamask/profile-sync-controller` from `^28.1.0` to `^28.2.0` ([#590](https://github.com/MetaMask/smart-transactions-controller/pull/590), [#598](https://github.com/MetaMask/smart-transactions-controller/pull/598))
 - Bump `@metamask/remote-feature-flag-controller` from `^4.2.1` to `^4.2.2` ([#590](https://github.com/MetaMask/smart-transactions-controller/pull/590))
 - Bump `@metamask/transaction-controller` from `^65.4.0` to `^68.0.0` ([#591](https://github.com/MetaMask/smart-transactions-controller/pull/591))
 - Bump `@metamask/utils` from `^11.0.0` to `^11.11.0` ([#590](https://github.com/MetaMask/smart-transactions-controller/pull/590))

package.json

@@ -41,7 +41,7 @@
     "test:watch": "jest --watchAll"
   },
   "dependencies": {
-    "@babel/runtime": "^7.24.1",
+    "@babel/runtime": "^7.23.9",
     "@ethereumjs/tx": "^5.4.0",
     "@ethereumjs/util": "^9.1.0",
     "@ethersproject/bytes": "^5.7.0",
@@ -54,7 +54,7 @@
     "@metamask/messenger": "^1.2.0",
     "@metamask/network-controller": "^32.0.0",
     "@metamask/polling-controller": "^16.0.6",
-    "@metamask/profile-sync-controller": "^28.1.1",
+    "@metamask/profile-sync-controller": "^28.2.0",
     "@metamask/remote-feature-flag-controller": "^4.2.2",
     "@metamask/superstruct": "^3.1.0",
     "@metamask/transaction-controller": "^68.0.0",
@@ -66,7 +66,7 @@
   },
   "devDependencies": {
     "@arethetypeswrong/cli": "^0.18.2",
-    "@lavamoat/allow-scripts": "^3.2.1",
+    "@lavamoat/allow-scripts": "^3.0.4",
     "@lavamoat/preinstall-always-fail": "^2.1.0",
     "@metamask/auto-changelog": "^6.1.0",
     "@metamask/eslint-config": "^15.0.0",
@@ -77,10 +77,6 @@
     "@metamask/json-rpc-engine": "^10.5.0",
     "@metamask/messenger-cli": "^0.2.0",
     "@ts-bridge/cli": "^0.6.4",
-    "@types/eslint": "^9.6.1",
-    "@types/jest": "^29.5.14",
-    "@types/lodash": "^4.14.194",
-    "@types/node": "^18.19.17",
     "eslint": "^9.39.1",
     "eslint-config-prettier": "^9.1.0",
     "eslint-import-resolver-typescript": "^3.6.3",
@@ -97,7 +93,7 @@
     "prettier-plugin-packagejson": "^2.4.3",
     "ts-jest": "^29.2.5",
     "typescript": "~5.3.3",
-    "typescript-eslint": "^8.39.0"
+    "typescript-eslint": "^8.48.0"
   },
   "peerDependenciesMeta": {
     "@metamask/accounts-controller": {