Skip to content

Commit 1afaeac

Browse files
authored
feat: migrate to @metamask/messenger-cli for action types codegen (#579)
* chore: use @metamask/messenger CLI for action type generation - Delete local scripts/generate-method-action-types.ts (755 lines) - Bump @metamask/messenger from ^0.3.0 to ^1.1.0 - Remove tsx devDependency (no longer needed) - Update generate script to use messenger-generate-action-types CLI * chore: add PR link to changelog entry * fix: add resolution to force @metamask/messenger@^1.1.0 * fix: format package.json with prettier * Revert "fix: format package.json with prettier" This reverts commit 566b7ff. * Revert "fix: add resolution to force @metamask/messenger@^1.1.0" This reverts commit c18ae36. * fix: remove tsx from lavamoat.allowScripts * feat: migrate to @metamask/messenger-cli for action types codegen * fix: prettier formatting
1 parent d323601 commit 1afaeac

5 files changed

Lines changed: 29 additions & 1070 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3838
- Consumers on TypeScript 4.x may experience type errors and should upgrade to TypeScript 5.x.
3939
- **BREAKING:** Replace `getBearerToken` constructor parameter with direct `AuthenticationController:getBearerToken` call ([#578](https://github.com/MetaMask/smart-transactions-controller/pull/578))
4040
- Consumers must add `AuthenticationController:getBearerToken` to the allowed actions in the controller messenger, and remove any usage of the `getBearerToken` constructor parameter.
41+
- Bump `@metamask/messenger` from `^0.3.0` to `^1.1.0` ([#578](https://github.com/MetaMask/smart-transactions-controller/pull/578))
4142

4243
## [23.0.0]
4344

package.json

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,13 @@
2929
],
3030
"scripts": {
3131
"build": "ts-bridge --project tsconfig.build.json --clean",
32-
"generate-method-action-types": "tsx ./scripts/generate-method-action-types.ts ./src",
33-
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn lint:changelog && yarn generate-method-action-types --check",
32+
"lint": "yarn lint:eslint && yarn lint:misc --check && yarn lint:changelog && yarn messenger-action-types:check",
3433
"lint:changelog": "auto-changelog validate --prettier",
3534
"lint:eslint": "eslint . --cache --ext js,ts",
36-
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:changelog && yarn generate-method-action-types --fix",
35+
"lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write && yarn lint:changelog && yarn messenger-action-types:generate",
3736
"lint:misc": "prettier '**/*.json' '**/*.md' '**/*.yml' '!.yarnrc.yml' --ignore-path .gitignore --no-error-on-unmatched-pattern",
37+
"messenger-action-types:check": "messenger-action-types --check",
38+
"messenger-action-types:generate": "messenger-action-types --generate",
3839
"prepack": "./scripts/prepack.sh",
3940
"test": "jest && attw --pack",
4041
"test:watch": "jest --watchAll"
@@ -74,6 +75,7 @@
7475
"@metamask/eslint-config-typescript": "^12.1.0",
7576
"@metamask/gas-fee-controller": "^26.0.0",
7677
"@metamask/json-rpc-engine": "^10.0.1",
78+
"@metamask/messenger-cli": "^0.1.0",
7779
"@ts-bridge/cli": "^0.6.3",
7880
"@types/eslint": "^9.6.1",
7981
"@types/jest": "^26.0.24",
@@ -97,9 +99,7 @@
9799
"prettier-plugin-packagejson": "^2.4.3",
98100
"sinon": "^9.2.4",
99101
"ts-jest": "^29.1.4",
100-
"tsx": "^4.20.5",
101-
"typescript": "~5.3.3",
102-
"yargs": "^17.7.2"
102+
"typescript": "~5.3.3"
103103
},
104104
"peerDependenciesMeta": {
105105
"@metamask/accounts-controller": {
@@ -131,7 +131,6 @@
131131
"@metamask/controller-utils>babel-runtime>core-js": false,
132132
"@metamask/transaction-controller>@metamask/core-backend>@metamask/keyring-controller>ethereumjs-wallet>ethereum-cryptography>keccak": false,
133133
"@metamask/transaction-controller>@metamask/core-backend>@metamask/keyring-controller>ethereumjs-wallet>ethereum-cryptography>secp256k1": false,
134-
"tsx>esbuild": false,
135134
"@metamask/profile-sync-controller>@metamask/keyring-controller>ethereumjs-wallet>ethereum-cryptography>keccak": false,
136135
"@metamask/profile-sync-controller>@metamask/keyring-controller>ethereumjs-wallet>ethereum-cryptography>secp256k1": false
137136
}

0 commit comments

Comments
 (0)