Skip to content

Commit a1ca475

Browse files
authored
chore: Update base-controller package (#529)
* chore: Update `base-controller` package The package `@metamask/base-controller` has been updated from v7 to v8. The only breaking changes impacting this package were some renamed exports (`ControllerMessenger` to `Messenger`, and `RestrictedControllerMessenger` to `RestrictedMessenger`). The `@metamask/polling-controller` package was updated as well, to stay in sync with the base controller version. This update unblocks #510 * Add changelog entry
1 parent 71adeb7 commit a1ca475

6 files changed

Lines changed: 71 additions & 321 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414
### Changed
1515

1616
- **BREAKING:** Disallow subpath exports ([#469](https://github.com/MetaMask/smart-transactions-controller/pull/469))
17+
- Update `@metamask/base-controller` from `^7.0.1` to `^8.3.0` ([#529](https://github.com/MetaMask/smart-transactions-controller/pull/529))
18+
- Update `@metamask/polling-controller` from `^12.0.0` to `^14.0.0` ([#529](https://github.com/MetaMask/smart-transactions-controller/pull/529))
1719

1820
## [18.1.0]
1921

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@
4545
"@ethersproject/bytes": "^5.7.0",
4646
"@ethersproject/keccak256": "^5.8.0",
4747
"@ethersproject/transactions": "^5.7.0",
48-
"@metamask/base-controller": "^7.0.1",
48+
"@metamask/base-controller": "^8.3.0",
4949
"@metamask/controller-utils": "^11.0.0",
5050
"@metamask/eth-json-rpc-provider": "^4.1.6",
5151
"@metamask/eth-query": "^4.0.0",
52-
"@metamask/polling-controller": "^12.0.0",
52+
"@metamask/polling-controller": "^14.0.0",
5353
"bignumber.js": "^9.0.1",
5454
"fast-json-patch": "^3.1.0",
5555
"lodash": "^4.17.21"

src/SmartTransactionsController.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ControllerMessenger } from '@metamask/base-controller';
1+
import { Messenger } from '@metamask/base-controller';
22
import {
33
NetworkType,
44
convertHexToDecimal,
@@ -2565,7 +2565,7 @@ async function withController<ReturnValue>(
25652565
): Promise<ReturnValue> {
25662566
const [{ ...rest }, fn] = args.length === 2 ? args : [{}, args[0]];
25672567
const { options } = rest;
2568-
const controllerMessenger = new ControllerMessenger<
2568+
const controllerMessenger = new Messenger<
25692569
| SmartTransactionsControllerActions
25702570
| NetworkControllerGetNetworkClientByIdAction
25712571
| NetworkControllerGetStateAction,

src/SmartTransactionsController.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { hexlify } from '@ethersproject/bytes';
22
import type {
33
ControllerGetStateAction,
44
ControllerStateChangeEvent,
5-
RestrictedControllerMessenger,
5+
RestrictedMessenger,
66
} from '@metamask/base-controller';
77
import {
88
query,
@@ -178,14 +178,13 @@ type AllowedEvents = NetworkControllerStateChangeEvent;
178178
/**
179179
* The messenger of the {@link SmartTransactionsController}.
180180
*/
181-
export type SmartTransactionsControllerMessenger =
182-
RestrictedControllerMessenger<
183-
typeof controllerName,
184-
SmartTransactionsControllerActions | AllowedActions,
185-
SmartTransactionsControllerEvents | AllowedEvents,
186-
AllowedActions['type'],
187-
AllowedEvents['type']
188-
>;
181+
export type SmartTransactionsControllerMessenger = RestrictedMessenger<
182+
typeof controllerName,
183+
SmartTransactionsControllerActions | AllowedActions,
184+
SmartTransactionsControllerEvents | AllowedEvents,
185+
AllowedActions['type'],
186+
AllowedEvents['type']
187+
>;
189188

190189
type SmartTransactionsControllerOptions = {
191190
interval?: number;

src/index.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ControllerMessenger } from '@metamask/base-controller';
1+
import { Messenger } from '@metamask/base-controller';
22
import {
33
type NetworkControllerGetNetworkClientByIdAction,
44
type NetworkControllerGetStateAction,
@@ -15,7 +15,7 @@ import { ClientId } from './types';
1515
describe('default export', () => {
1616
it('exports SmartTransactionsController', () => {
1717
jest.useFakeTimers();
18-
const controllerMessenger = new ControllerMessenger<
18+
const controllerMessenger = new Messenger<
1919
| SmartTransactionsControllerActions
2020
| NetworkControllerGetNetworkClientByIdAction
2121
| NetworkControllerGetStateAction,

0 commit comments

Comments
 (0)