Add new tests

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>

Author: dan437

src/SmartTransactionsController.test.ts

@@ -2090,6 +2090,126 @@ describe('SmartTransactionsController', () => {
       );
     });
   });
+
+  describe('createOrUpdateSmartTransaction', () => {
+    beforeEach(() => {
+      jest
+        .spyOn(SmartTransactionsController.prototype, 'checkPoll')
+        .mockImplementation(() => ({}));
+    });
+
+    it('adds metaMetricsProps to new smart transactions', async () => {
+      const { smartTransactionsState } =
+        getDefaultSmartTransactionsControllerState();
+      const newSmartTransaction = {
+        uuid: 'new-uuid-test',
+        status: SmartTransactionStatuses.PENDING,
+        txParams: {
+          from: addressFrom,
+        },
+      };
+
+      await withController(
+        {
+          options: {
+            state: {
+              smartTransactionsState: {
+                ...smartTransactionsState,
+                smartTransactions: {
+                  [ChainId.mainnet]: [],
+                },
+              },
+            },
+            getMetaMetricsProps: jest.fn().mockResolvedValue({
+              accountHardwareType: 'Test Hardware',
+              accountType: 'test-account',
+              deviceModel: 'test-model',
+            }),
+          },
+        },
+        async ({ controller }) => {
+          controller.updateSmartTransaction(
+            newSmartTransaction as SmartTransaction,
+          );
+
+          // Allow async operations to complete
+          await flushPromises();
+
+          // Verify MetaMetricsProps were added
+          const updatedTransaction =
+            controller.state.smartTransactionsState.smartTransactions[
+              ChainId.mainnet
+            ][0];
+          expect(updatedTransaction.accountHardwareType).toBe('Test Hardware');
+          expect(updatedTransaction.accountType).toBe('test-account');
+          expect(updatedTransaction.deviceModel).toBe('test-model');
+        },
+      );
+    });
+
+    it('continues without metaMetricsProps if adding them fails', async () => {
+      const { smartTransactionsState } =
+        getDefaultSmartTransactionsControllerState();
+      const newSmartTransaction = {
+        uuid: 'new-uuid-test',
+        status: SmartTransactionStatuses.PENDING,
+        txParams: {
+          from: addressFrom,
+        },
+      };
+
+      // Mock console.error to verify it's called
+      const consoleErrorSpy = jest.spyOn(console, 'error').mockImplementation();
+
+      await withController(
+        {
+          options: {
+            state: {
+              smartTransactionsState: {
+                ...smartTransactionsState,
+                smartTransactions: {
+                  [ChainId.mainnet]: [],
+                },
+              },
+            },
+            // Mock getting MetaMetricsProps to fail
+            getMetaMetricsProps: jest
+              .fn()
+              .mockRejectedValue(new Error('Test metrics error')),
+          },
+        },
+        async ({ controller }) => {
+          controller.updateSmartTransaction(
+            newSmartTransaction as SmartTransaction,
+          );
+
+          // Allow async operations to complete
+          await flushPromises();
+
+          // Verify transaction was still added even without metrics props
+          const updatedTransaction =
+            controller.state.smartTransactionsState.smartTransactions[
+              ChainId.mainnet
+            ][0];
+          expect(updatedTransaction.uuid).toBe('new-uuid-test');
+
+          // These should be undefined since getting metrics props failed
+          expect(updatedTransaction.accountHardwareType).toBeUndefined();
+          expect(updatedTransaction.accountType).toBeUndefined();
+          expect(updatedTransaction.deviceModel).toBeUndefined();
+
+          // Verify the error was logged
+          expect(consoleErrorSpy).toHaveBeenCalledWith(
+            'Failed to add metrics props to smart transaction:',
+            expect.any(Error),
+          );
+
+          // Clean up the spy
+          consoleErrorSpy.mockRestore();
+        },
+      );
+    });
+  });
 });
 
 type WithControllerCallback<ReturnValue> = ({